Skip to content

scsi-disk: Device Identification fixes

Kevin Wolf qemu-devel 1 version Applied

Status from this message: Applied patches 1 and 2 to the block branch so that the bug is fixed.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 16 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3scsi-disk: Don't use empty string as device idhw/scsi/scsi-disk.c+8 -63 replies
2/3scsi-disk: Add device_id propertyhw/scsi/scsi-disk.c+16 -88 replies
3/3scsi-disk: Deprecate device_id fallback to BlockBackend namehw/scsi/scsi-disk.c qemu-deprecated.texi+26 -13 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakePhilippe Mathieu-Daudé
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes

The vendor specific designator in the Device Identification VPD page has two problems:

1. It defaults to the BlockBackend name (-drive id=...), which everyone expected to be a host detail that the guest never sees

2. With -blockdev based setups it defaults to an empty string; if this default is used with more than one disk, the guest OS will interpret this as a single multipath disk.

We can address problem 2 immediately, and start running the deprecation clock for problem 1.

Related bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=1669446
https://bugzilla.redhat.com/show_bug.cgi?id=1668248

Kevin Wolf (3):
scsi-disk: Don't use empty string as device id
scsi-disk: Add device_id property
scsi-disk: Deprecate device_id fallback to BlockBackend name

 hw/scsi/scsi-disk.c  | 41 ++++++++++++++++++++++++++++-------------
 qemu-deprecated.texi | 22 +++++++++++++++++++++-
 2 files changed, 49 insertions(+), 14 deletions(-)
Signature · 1 line
2.20.1