scsi-disk: Device Identification fixes
Status from this message: Applied patches 1 and 2 to the block branch so that the bug is fixed.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi-disk: Don't use empty string as device idhw/ | +8 | 3 replies | |
| 2/3 | scsi-disk: Add device_id propertyhw/ | +16 | 8 replies | |
| 3/3 | scsi-disk: Deprecate device_id fallback to BlockBackend namehw/ qemu-deprecated.texi | +26 | 3 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Eric Blake | Philippe Mathieu-Daudé |
|---|---|---|
| Series | R-b | |
| 1/3 | R-b | |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/3] scsi-disk: Device Identification fixes
The vendor specific designator in the Device Identification VPD page has two problems:
1. It defaults to the BlockBackend name (-drive id=...), which everyone expected to be a host detail that the guest never sees
2. With -blockdev based setups it defaults to an empty string; if this default is used with more than one disk, the guest OS will interpret this as a single multipath disk.
We can address problem 2 immediately, and start running the deprecation clock for problem 1.
Related bug reports:
https://bugzilla.redhat.com/show_bug.cgi?id=1669446
https://bugzilla.redhat.com/show_bug.cgi?id=1668248
Kevin Wolf (3):
scsi-disk: Don't use empty string as device id
scsi-disk: Add device_id property
scsi-disk: Deprecate device_id fallback to BlockBackend name
hw/scsi/scsi-disk.c | 41 ++++++++++++++++++++++++++++------------- qemu-deprecated.texi | 22 +++++++++++++++++++++- 2 files changed, 49 insertions(+), 14 deletions(-)
Signature · 1 line
2.20.1