Skip to content

tcp: change pingpong to 3 in delayed ack logic

Wei Wang netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcp: Refactor pingpong codeinclude/net/inet_connection_sock.h net/dccp/input.c net/dccp/timer.c +6 more+35 -180 replies
2/2tcp: change pingpong threshold to 3include/net/inet_connection_sock.h net/ipv4/tcp_output.c+18 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] tcp: change pingpong to 3 in delayed ack logic

TCP receiver today tries not to delay the ACKs to speed up the initial slow start (a.k.a QUICK ACK mechanism). However the previous design does not work well with modern TCP applications that starts with an application-level handshake. For example, a HTTPs server often receives the SSL hello and responds right away which triggers the TCP stack to stop the quick ack and start delaying the ACKs based only one instance of ping-pong. This patchset changes the threshold from 1 to 3 ping-pong transactions, so that we only start to delay the acks after the receiver responds data quickly three times.

Wei Wang (2):
tcp: Refactor pingpong code
tcp: change pingpong threshold to 3

 include/net/inet_connection_sock.h | 25 +++++++++++++++++++++++++
 net/dccp/input.c                   |  2 +-
 net/dccp/timer.c                   |  4 ++--
 net/ipv4/tcp.c                     | 10 +++++-----
 net/ipv4/tcp_input.c               |  8 ++++----
 net/ipv4/tcp_ipv4.c                |  2 +-
 net/ipv4/tcp_output.c              | 17 ++++++++++-------
 net/ipv4/tcp_timer.c               |  4 ++--
 net/ipv6/tcp_ipv6.c                |  2 +-
 9 files changed, 51 insertions(+), 23 deletions(-)
Signature · 1 line
2.20.1.321.g9e740568ce-goog