Skip to content

mm, memory_hotplug: fix uninitialized pages fallouts.

Michal Hocko linux-mm lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 14 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm, memory_hotplug: is_mem_section_removable do not pass the end of a zonemm/memory_hotplug.c+2 -10 replies
2/2mm, memory_hotplug: test_pages_in_a_zone do not pass the end of zonemm/memory_hotplug.c+3 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMikhail ZaslonkoGerald SchaeferMikhail GavrilovOscar Salvador
1/2Debugged-by T-b T-b R-b
2/2T-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] mm, memory_hotplug: fix uninitialized pages fallouts.

Hi,
this is the second version of the series. v1 was posted [1]. There are no functional changes since v1. I have just fixed up the changelog of patch 1 which had a wrong trace (c&p mistake). I have also added tested-bys and reviewed-bys.

Mikhail has posted fixes for the two bugs quite some time ago [2]. I have pushed back on those fixes because I believed that it is much better to plug the problem at the initialization time rather than play whack-a-mole all over the hotplug code and find all the places which expect the full memory section to be initialized. We have ended up with 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full memory section") merged and cause a regression [3][4]. The reason is that there might be memory layouts when two NUMA nodes share the same memory section so the merged fix is simply incorrect.

In order to plug this hole we really have to be zone range aware in those handlers. I have split up the original patch into two. One is unchanged (patch 2) and I took a different approach for `removable' crash. It would be great if Mikhail could test it still works for his memory layout.

[1] http://lkml.kernel.org/r/[email protected]
[2] http://lkml.kernel.org/r/[email protected]
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1666948
[4] http://lkml.kernel.org/r/[email protected]