Skip to content

Register an Energy Model for Arm reference platforms

Quentin Perret linux-arm-kernel linux-pm lkml 4 versions – Applied

Status from this message: Applied. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 3 repliesApplied
  2. v35 patches 7 repliesSuperseded
  3. v25 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches17 repliesSuperseded

Changes in v4 from the cover letter

- Moved the OPP count inside dev_pm_opp_of_register_em() (Matthias, Sudeep)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/5PM / OPP: Introduce a power estimation helperdrivers/opp/of.c include/linux/pm_opp.h+105 -02 replies
2/5cpufreq: dt: Register an Energy Modeldrivers/cpufreq/cpufreq-dt.c+2 -00 replies
3/5cpufreq: scpi: Register an Energy Modeldrivers/cpufreq/scpi-cpufreq.c+3 -00 replies
4/5cpufreq: arm_big_little: Register an Energy Modeldrivers/cpufreq/arm_big_little.c+2 -00 replies
5/5cpufreq: scmi: Register an Energy Modeldrivers/cpufreq/scmi-cpufreq.c+36 -30 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMatthias Kaehlcke
1/5T-b R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Register an Energy Model for Arm reference platforms

The Energy Model (EM) framework feeds interested subsystems (the scheduler/EAS as of now) with power costs provided by drivers. Yet, no driver is actually doing that upstream yet. This series updates a set of CPUFreq drivers in order to register power costs in the EM framework for some of the Arm reference platforms for EAS: Hikey960, Juno and TC2.

The series is split as follows:
- Patch 01 introduces in PM_OPP a helper function which estimates the CPU power using the P=CV²f equation also used by IPA. It should be noted that this introduces duplicate code with IPA, which will eventually be fixed by migrating IPA to using PM_EM. The ideal plan would be to do so later, in a separate patch series. I would indeed prefer to keep the thermal and CPUFreq discussion separate at this stage, if deemed acceptable.
- Patches 02-04 make use of that PM_OPP helper function from the following CPUFreq drivers: cpufreq-dt, scpi-cpufreq and arm_big_little.
- Patch 05 modifies the SCMI cpufreq driver to pass the power costs obtained from firmware to PM_EM. This patch is independent from the rest of the series.

Changes since v3 ([email protected])
- Moved the OPP count inside dev_pm_opp_of_register_em() (Matthias, Sudeep)

Changes since v2 ([email protected])
- Added comment to explain why we check only the dynamic-power-coeff property and not voltages in dev_pm_opp_of_register_em() (Viresh)
- Fixed comments/docstrings of new functions in opp/of.c (Matthias)
- Added Matthias' Tested-by to patch 01

Changes since v1 ([email protected]):
- Dropped the DT patches that have been queued by Sudeep
- Introduced dev_pm_opp_of_register_em() helper to check the presence of the DT coeff before calling PM_EM (Viresh, Matthias)
- Coding-style improvements (Viresh, Matthias)

Thanks,
Quentin

Dietmar Eggemann (1):
cpufreq: arm_big_little: Register an Energy Model

Quentin Perret (4):
PM / OPP: Introduce a power estimation helper
cpufreq: dt: Register an Energy Model
cpufreq: scpi: Register an Energy Model
cpufreq: scmi: Register an Energy Model

 drivers/cpufreq/arm_big_little.c |  2 +
 drivers/cpufreq/cpufreq-dt.c     |  2 +
 drivers/cpufreq/scmi-cpufreq.c   | 39 ++++++++++++-
 drivers/cpufreq/scpi-cpufreq.c   |  3 +
 drivers/opp/of.c                 | 99 ++++++++++++++++++++++++++++++++
 include/linux/pm_opp.h           |  6 ++
 6 files changed, 148 insertions(+), 3 deletions(-)
Signature · 1 line
2.20.1