Skip to content

Trivial cleanup in hw/acpi

Wei Yang qemu-devel qemu-trivial 3 versions – Applied

Status from this message: Applied to my trivial-patches branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesApplied
  2. v33 patches 24 repliesSuperseded
  3. v23 patches 12 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3hw/i386/pc.c: remove unused function pc_acpi_init()hw/i386/pc.c include/hw/i386/pc.h+0 -281 reply
2/3hw/acpi: remove unused function acpi_table_add_builtin()hw/acpi/core.c include/hw/acpi/acpi.h+0 -71 reply
3/3hw/acpi: remove unnecessary variable acpi_table_builtinhw/acpi/core.c+1 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéIgor MammedovThomas Huth
1/3R-b T-b R-b R-b
2/3R-b T-b R-b
3/3R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [Qemu-devel] [Patch v4 0/3] Trivial cleanup in hw/acpi

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v4: fix reviewed-by tags
v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

 hw/acpi/core.c         | 10 +---------
 hw/i386/pc.c           | 27 ---------------------------
 include/hw/acpi/acpi.h |  1 -
 include/hw/i386/pc.h   |  1 -
 4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1