block: local qiov helper
Status from this message: Thanks, applied to my block tree:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
01: tiny improvements by Eric
+ fix bug: s/niov/nalloc in assertion
+ rename s/qemu_iovec_get_buf/qemu_iovec_buf,
to don't look like getter, which in turn should not return pointer to something internal to be freed separately.
So, no r-b's in 01
07,10,16
- rebase on new function name qemu_iovec_buf
- save r-b's by Eric and Stefan
others unchanged, add r-b's by Eric and Stefan
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | block: enhance QEMUIOVector structureinclude/ | +62 | 1 reply | |
| 2/17 | block/io: use qemu_iovec_init_bufblock/ | +20 | 0 replies | |
| 3/17 | block/block-backend: use QEMU_IOVEC_INIT_BUFblock/ | +2 | 0 replies | |
| 4/17 | block/backup: use qemu_iovec_init_bufblock/ | +1 | 0 replies | |
| 5/17 | block/commit: use QEMU_IOVEC_INIT_BUFblock/ | +1 | 0 replies | |
| 6/17 | block/stream: use QEMU_IOVEC_INIT_BUFblock/ | +1 | 0 replies | |
| 7/17 | block/parallels: use QEMU_IOVEC_INIT_BUFblock/ | +5 | 0 replies | |
| 8/17 | block/qcow: use qemu_iovec_init_bufblock/ | +4 | 0 replies | |
| 9/17 | block/qcow2: use qemu_iovec_init_bufblock/ | +2 | 0 replies | |
| 10/17 | block/qed: use qemu_iovec_init_bufblock/ block/ | +12 | 0 replies | |
| 11/17 | block/vmdk: use qemu_iovec_init_bufblock/ | +1 | 0 replies | |
| 12/17 | qemu-img: use qemu_iovec_init_bufqemu-img.c | +2 | 0 replies | |
| 13/17 | migration/block: use qemu_iovec_init_bufmigration/ | +3 | 0 replies | |
| 14/17 | tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUFtests/ | +4 | 0 replies | |
| 15/17 | hw/ide: drop iov field from IDEStatehw/ hw/ include/ | +6 | 0 replies | |
| 16/17 | hw/ide: drop iov field from IDEBufferedRequesthw/ include/ | +6 | 0 replies | |
| 17/17 | hw/ide: drop iov field from IDEDMAhw/ include/ | +2 | 0 replies |
Reviews trailers per patch
All 17 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Stefan Hajnoczi |
|---|---|---|
| 1/17 | R-b | |
| 2/17 | R-b | R-b |
| 3/17 | R-b | R-b |
| 4/17 | R-b | R-b |
| 5/17 | R-b | R-b |
| 6/17 | R-b | R-b |
| 7/17 | R-b | R-b |
| 8/17 | R-b | R-b |
| 9/17 | R-b | R-b |
| 10/17 | R-b | R-b |
| 11/17 | R-b | R-b |
| 12/17 | R-b | R-b |
| 13/17 | R-b | R-b |
| 14/17 | R-b | R-b |
| 15/17 | R-b | R-b |
| 16/17 | R-b | R-b |
| 17/17 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 00/17] block: local qiov helper
Hi all!
Here is a new simple helper for a very often patter around qemu_iovec_init_external, when we need simple qiov with only one iov, initialized from external buffer.
v4:
01: tiny improvements by Eric
+ fix bug: s/niov/nalloc in assertion
+ rename s/qemu_iovec_get_buf/qemu_iovec_buf,
to don't look like getter, which in turn should not return pointer to something internal to be freed separately.
So, no r-b's in 01
07,10,16
- rebase on new function name qemu_iovec_buf
- save r-b's by Eric and Stefan
others unchanged, add r-b's by Eric and Stefan
v3:
01-02: tiny improvements, described in patch-emails 03-17: new patches
Note: only hw/scsi/scsi-disk.c not updated, as it has too tricky
logic around @iov fields of structures. So, it is simpler to keep it as is.
v2 was "[PATCH v2 0/2] block: local qiov helper: part I"
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01610.html
Vladimir Sementsov-Ogievskiy (17):
block: enhance QEMUIOVector structure
block/io: use qemu_iovec_init_buf
block/block-backend: use QEMU_IOVEC_INIT_BUF
block/backup: use qemu_iovec_init_buf
block/commit: use QEMU_IOVEC_INIT_BUF
block/stream: use QEMU_IOVEC_INIT_BUF
block/parallels: use QEMU_IOVEC_INIT_BUF
block/qcow: use qemu_iovec_init_buf
block/qcow2: use qemu_iovec_init_buf
block/qed: use qemu_iovec_init_buf
block/vmdk: use qemu_iovec_init_buf
qemu-img: use qemu_iovec_init_buf
migration/block: use qemu_iovec_init_buf
tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF
hw/ide: drop iov field from IDEState
hw/ide: drop iov field from IDEBufferedRequest
hw/ide: drop iov field from IDEDMA
include/hw/ide/internal.h | 3 -- include/qemu/iov.h | 64 +++++++++++++++++++++++++++- block/backup.c | 5 +-- block/block-backend.c | 13 +----- block/commit.c | 7 +-- block/io.c | 89 +++++++++------------------------------ block/parallels.c | 13 +++--- block/qcow.c | 21 ++------- block/qcow2.c | 12 +----- block/qed-table.c | 16 ++----- block/qed.c | 31 ++++---------- block/stream.c | 7 +-- block/vmdk.c | 7 +-- hw/ide/atapi.c | 14 +++--- hw/ide/core.c | 19 ++++----- migration/block.c | 10 ++--- qemu-img.c | 10 +---- tests/test-bdrv-drain.c | 29 ++----------- 18 files changed, 134 insertions(+), 236 deletions(-)
Signature · 1 line
2.18.0