Skip to content

block: local qiov helper

Vladimir Sementsov-Ogievskiy qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 2 repliesApplied
  2. v317 patches 23 repliesApplied
  3. v22 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches6 repliesSuperseded

Changes in v4 from the cover letter

01: tiny improvements by Eric
+ fix bug: s/niov/nalloc in assertion
+ rename s/qemu_iovec_get_buf/qemu_iovec_buf,
to don't look like getter, which in turn should not return pointer to something internal to be freed separately.
So, no r-b's in 01
07,10,16
- rebase on new function name qemu_iovec_buf
- save r-b's by Eric and Stefan
others unchanged, add r-b's by Eric and Stefan

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/17block: enhance QEMUIOVector structureinclude/qemu/iov.h+62 -21 reply
2/17block/io: use qemu_iovec_init_bufblock/io.c+20 -690 replies
3/17block/block-backend: use QEMU_IOVEC_INIT_BUFblock/block-backend.c+2 -110 replies
4/17block/backup: use qemu_iovec_init_bufblock/backup.c+1 -40 replies
5/17block/commit: use QEMU_IOVEC_INIT_BUFblock/commit.c+1 -60 replies
6/17block/stream: use QEMU_IOVEC_INIT_BUFblock/stream.c+1 -60 replies
7/17block/parallels: use QEMU_IOVEC_INIT_BUFblock/parallels.c+5 -80 replies
8/17block/qcow: use qemu_iovec_init_bufblock/qcow.c+4 -170 replies
9/17block/qcow2: use qemu_iovec_init_bufblock/qcow2.c+2 -100 replies
10/17block/qed: use qemu_iovec_init_bufblock/qed-table.c block/qed.c+12 -350 replies
11/17block/vmdk: use qemu_iovec_init_bufblock/vmdk.c+1 -60 replies
12/17qemu-img: use qemu_iovec_init_bufqemu-img.c+2 -80 replies
13/17migration/block: use qemu_iovec_init_bufmigration/block.c+3 -70 replies
14/17tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUFtests/test-bdrv-drain.c+4 -250 replies
15/17hw/ide: drop iov field from IDEStatehw/ide/atapi.c hw/ide/core.c include/hw/ide/internal.h+6 -120 replies
16/17hw/ide: drop iov field from IDEBufferedRequesthw/ide/core.c include/hw/ide/internal.h+6 -60 replies
17/17hw/ide: drop iov field from IDEDMAhw/ide/atapi.c include/hw/ide/internal.h+2 -40 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchEric BlakeStefan Hajnoczi
1/17R-b
2/17R-b R-b
3/17R-b R-b
4/17R-b R-b
5/17R-b R-b
6/17R-b R-b
7/17R-b R-b
8/17R-b R-b
9/17R-b R-b
10/17R-b R-b
11/17R-b R-b
12/17R-b R-b
13/17R-b R-b
14/17R-b R-b
15/17R-b R-b
16/17R-b R-b
17/17R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 00/17] block: local qiov helper

Hi all!

Here is a new simple helper for a very often patter around qemu_iovec_init_external, when we need simple qiov with only one iov, initialized from external buffer.

v4:
01: tiny improvements by Eric
+ fix bug: s/niov/nalloc in assertion
+ rename s/qemu_iovec_get_buf/qemu_iovec_buf,
to don't look like getter, which in turn should not return pointer to something internal to be freed separately.
So, no r-b's in 01
07,10,16
- rebase on new function name qemu_iovec_buf
- save r-b's by Eric and Stefan
others unchanged, add r-b's by Eric and Stefan

v3:
01-02: tiny improvements, described in patch-emails 03-17: new patches

Note: only hw/scsi/scsi-disk.c not updated, as it has too tricky
logic around @iov fields of structures. So, it is simpler to keep it as is.

v2 was "[PATCH v2 0/2] block: local qiov helper: part I"
https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01610.html

Vladimir Sementsov-Ogievskiy (17):
block: enhance QEMUIOVector structure
block/io: use qemu_iovec_init_buf
block/block-backend: use QEMU_IOVEC_INIT_BUF
block/backup: use qemu_iovec_init_buf
block/commit: use QEMU_IOVEC_INIT_BUF
block/stream: use QEMU_IOVEC_INIT_BUF
block/parallels: use QEMU_IOVEC_INIT_BUF
block/qcow: use qemu_iovec_init_buf
block/qcow2: use qemu_iovec_init_buf
block/qed: use qemu_iovec_init_buf
block/vmdk: use qemu_iovec_init_buf
qemu-img: use qemu_iovec_init_buf
migration/block: use qemu_iovec_init_buf
tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF
hw/ide: drop iov field from IDEState
hw/ide: drop iov field from IDEBufferedRequest
hw/ide: drop iov field from IDEDMA

 include/hw/ide/internal.h |  3 --
 include/qemu/iov.h        | 64 +++++++++++++++++++++++++++-
 block/backup.c            |  5 +--
 block/block-backend.c     | 13 +-----
 block/commit.c            |  7 +--
 block/io.c                | 89 +++++++++------------------------------
 block/parallels.c         | 13 +++---
 block/qcow.c              | 21 ++-------
 block/qcow2.c             | 12 +-----
 block/qed-table.c         | 16 ++-----
 block/qed.c               | 31 ++++----------
 block/stream.c            |  7 +--
 block/vmdk.c              |  7 +--
 hw/ide/atapi.c            | 14 +++---
 hw/ide/core.c             | 19 ++++-----
 migration/block.c         | 10 ++---
 qemu-img.c                | 10 +----
 tests/test-bdrv-drain.c   | 29 ++-----------
 18 files changed, 134 insertions(+), 236 deletions(-)
Signature · 1 line
2.18.0