RFC Rewrite route stress tests into C
Get series with b4
b4 am 20190129181856.GA17728@dell5510Versions newest first
- v1 RFC Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [RFC PATCH 0/2] Rewrite route stress tests into C
Hi Alexey,
thanks for your comments.
Quoted 9 lines
Quoted 4 lines
Some issues:
* The test is only on lhost, no attempt to set iface on rhost and check connection. The only check is done via error of libnl used. It's questionable whether this way is good enough.True, it would be better to verify that the route is working and usable.
At least, we could open a socket and send something using the route (ns-udpsender way)...
OK, I'll try at least this. And if it's not suitable enough, I'll have to get back to shell (or I'd have to implement tst_rhost_run() in C).
Quoted 10 lines
Quoted 9 lines
If we want to have established connection, it'd be better to get back to shell testing [1], just replace netstress to new tool (I'd prefer not use ns-udpsender).>
* rtnetlink is used via libnl, which is very lazy approach.
As subject of testing is route testing and not rtnetlink testing I didn't reimplement rtnetlink socket communication from scratch, but I guess I should. Also using link caching (used by functions from libnl-cli) might not be a good idea (maybe using libmnl or only libnl-route would be better if using library).
Quoted 2 lines
And libmnl has an example:
https://git.netfilter.org/libmnl/tree/examples/rtnl/rtnl-route-add.c
I noticed this as well, I'll use libmnl.
Kind regards,
Petr