Skip to content

RFC dm, efi: integrate efi objects into DM

AKASHI Takahiro u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest posting 3/30 of 15 patches 0 repliesNew
  2. v2 RFC posting 2/30 of 15 patches 0 repliesSuperseded
  3. v2 RFC posting 1/315 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC0 of 3 patches0 repliesSuperseded

Patches in v2 posting 3/3 No applies recorded yet

None of the 15 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [RFC v2 00/15] dm, efi: integrate efi objects into DM
Quoted 10 lines · Simon Glass

Hi Takahiro,

Quoted 7 lines · AKASHI Takahiro
# bootefi doesn't work with this patch set yet

This patch set came from the past discussion[1] on my "removable device support" patch and is intended to be an attempt to integrate efi objects
into u-boot's Driver Model as much seamlessly as possible.

Quoted 5 lines
Quoted 1 line

[1] https://lists.denx.de/pipermail/u-boot/2019-January/354010.html

Some general comments:

protocol_list: Can you use DM_GET_DRIVER? It should be more efficient

Okay.

Quoted 2 lines

efi_open_protocol_information:
- rename of protocol to protocol_guid should be in a separate patch

Okay, but I may will rename other argument names instead.

Quoted 1 line

u-boot - please use 'U-Boot' consistently

Sure.

Quoted 5 lines

Your patch to rename UCLASS_EFI -> UCLASS_EFI_DRIVER still leaves UCLASS_EFI remaining. Can you mention why>

It says efi_root is for backward compatibility. Just temporary? I could not quite figure that out.

The concept of "efi_root" is a discussion.

Quoted 1 line

Use if (IS_ENABLED()) instead of #ifdef where you can.

Okay

Quoted 3 lines

I am very encouraged by this series as it genuinely unifies EFI with DM. Re your comment about wrapper code, I suspect that might become clearer once the data structures are unified.

Your comments also encourage me very much.

Thanks!
-Takahiro Akashi

Quoted 2 lines

Regards,
Simon