Skip to content

ALSA: pcm: anonymous dup implementation

Jaroslav Kysela alsa-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesIn review
  2. v53 patches 2 repliesSuperseded
  3. v42 patches 15 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches18 repliesSuperseded

Changes in v6 from the cover letter

- add proper open_mutex protection for snd_pcm_open_file()

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ALSA: pcm: implement the anonymous dup (inode file descriptor)include/sound/pcm.h include/uapi/sound/asound.h sound/core/oss/pcm_oss.c +3 more+77 -190 replies
2/3ALSA: pcm: merge pcm_..._mmap_allowed fcns to the snd_pcm_mmap_... fcnssound/core/pcm_native.c+22 -340 replies
3/3ALSA: pcm: implement the mmap buffer mode for the anonymous dupinclude/sound/pcm.h include/uapi/sound/asound.h sound/core/pcm_native.c+38 -40 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTakashi IwaiMark Brown
SeriesR-b
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] ALSA: pcm: anonymous dup implementation

This patchset contains the anonymous dup implementation with permissions checking for the ALSA's PCM interface in kernel to enable the restricted DMA sound buffer sharing for the restricted tasks.

The code was tested through qemu and it seems to be pretty stable.

The initial tinyalsa implementation can be found here:

https://github.com/perexg/tinyalsa/commits/anondup

The filtering might be refined. It depends on the real requirements. Perhaps, we may create more ioctl groups. Any comments are more than welcome.

v2 of the patches:

- change clone parameter to subdevice number for the pcm attach
- change SNDRV_PCM_PERM_MAX to SNDRV_PCM_PERM_MASK
- the tinyalsa implementation was a little updated (restructured)

v3 of the patches:

- group integer declarations in snd_pcm_anonymous_dup()
- replaced substream->pcm with pcm in snd_pcm_anonymous_dup()
- added SNDRV_PCM_PERM_RW check for read/write/readv/writev syscalls

v4 of the patches:

- more simple restriction control (only two modes - full/buffer)
- the tinyalsa implementation follows this change

v5 of the patches:

- merge pcm_..._mmap_allowed fcns to the snd_pcm_mmap_... fcns

v6:

- add proper open_mutex protection for snd_pcm_open_file()

Cc Phil Burk <[email protected]>
Cc Zach Riggle <[email protected]>
Cc Mark Brown <[email protected]>
Cc Leo Yan <[email protected]>
Cc Baolin Wang <[email protected]>

Jaroslav Kysela (3):
ALSA: pcm: implement the anonymous dup (inode file descriptor)
ALSA: pcm: merge pcm_..._mmap_allowed fcns to the snd_pcm_mmap_...
fcns
ALSA: pcm: implement the mmap buffer mode for the anonymous dup

 include/sound/pcm.h         |  10 +--
 include/uapi/sound/asound.h |   6 +-
 sound/core/oss/pcm_oss.c    |   2 +-
 sound/core/pcm.c            |  13 ++--
 sound/core/pcm_compat.c     |   1 +
 sound/core/pcm_native.c     | 154 +++++++++++++++++++++++++++++++++-----------
 6 files changed, 133 insertions(+), 53 deletions(-)
Signature · 1 line
2.13.6