Skip to content

mx6sabre: Add DM and SPL FIT support

Tom Rini u-boot 6 versions – New

Get series with b4
b4 am 20190204153001.GB30838@bill-the-cat

Versions newest first · linked by author and title

  1. v4 Latest posting 3/30 of 20 patches 0 repliesNew
  2. v4 posting 2/30 of 20 patches 0 repliesSuperseded
  3. v4 posting 1/31 of 20 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 3/30 of 22 patches0 repliesSuperseded
v3 posting 2/30 of 22 patches0 repliesSuperseded
v3 posting 1/30 of 22 patches0 repliesSuperseded

Patches in v4 posting 3/3 No applies recorded yet

None of the 20 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support
Quoted 25 lines · Simon Goldschmidt

Am Mo., 4. Feb. 2019, 16:16 hat Abel Vesa <[email protected]> geschrieben:

Quoted 23 lines · Tom Rini
Quoted 4 lines · Fabio Estevam
Quoted 3 lines · Abel Vesa
Quoted 2 lines

If the SPL size (without the dtb appended) is larger then yes, the

build fails.

Quoted 1 line
Quoted 1 line
Quoted 1 line

Trouble is if the SPL (without the dtb appended) is, lets say, 63kB

and

Quoted 1 line
Quoted 1 line
Quoted 1 line

then the dtb is larger than 1kB. Then there is no mechanism in place

to check that

Quoted 1 line
Quoted 1 line
Quoted 1 line

and it will just fail to boot without giving any clues why. But this

is a totally

Quoted 1 line
Quoted 1 line
Quoted 1 line

unrelated problem from this patchset's point of view and I think it

impacts all

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

the platforms that support SPL with DM.

Yes, it is unrelated to this series and should be treated separately.

I also agree. But, don't we have a mechanism for that? It sounds like some additional targets need to call $(BOARD_SIZE_CHECK) at the end. Or am I missing something?

Quoted 8 lines
Quoted 2 lines

Hmm, I believe that is true. I haven't looked deeper into it but it seems that's the thing the SPL is missing.

Haven't we talked about that just some days or weeks ago? That's exactly what I am missing for socfpga. I keep getting broken SPL images when adding functionality. And you don't even get an error message because the dtb is broken and cannot provide the serial output mode...

Yes, I believe it is. I guess what I'm waiting / hoping for is someone to patch the top-level Makefile to call $(BOARD_SIZE_CHECK) on a number of make targets that look reasonable, throw it at travis and see what if anything fails (and if stuff fails, ask for help to see if it's right or investigate a bit more). More or less, if it's a final target for U-Boot, we should probably give BOARD_SIZE_CHECK a try. Most of the rules start with u-boot, but I bet the %.imx target should also do it, and then we can drop all of that from arch/arm/mach-imx/Makefile.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190204/e880d7c4/attachment.sig>