Skip to content

tools/bpf: changes of libbpf debug interfaces

Yonghong Song netdev 4 versions – Applied

Status from this message: Applied to bpf-next. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesApplied
  2. v33 patches 2 repliesSuperseded
  3. v23 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches0 repliesSuperseded

Changes in v4 from the cover letter

. rename libbpf internal header util.h to libbpf_util.h
. rename libbpf internal function libbpf_debug_print() to libbpf_print()

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3tools/bpf: move libbpf pr_* debug print functions to headerstools/lib/bpf/btf.c tools/lib/bpf/btf.h tools/lib/bpf/libbpf.c +3 more+120 -700 replies
2/3tools/bpf: print out btf log at LIBBPF_WARN leveltools/lib/bpf/btf.c tools/lib/bpf/libbpf.c tools/lib/bpf/libbpf_util.h+9 -220 replies
3/3tools/bpf: simplify libbpf API function libbpf_set_print()tools/lib/bpf/libbpf.c tools/lib/bpf/libbpf.h tools/lib/bpf/test_libbpf.cpp +4 more+68 -760 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArnaldo Carvalho de Melo
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH bpf-next v4 0/3] tools/bpf: changes of libbpf debug interfaces

These are patches responding to my comments for Magnus's patch (https://patchwork.ozlabs.org/patch/1032848/).
The goal is to make pr_* macros available to other C files than libbpf.c, and to simplify API function libbpf_set_print().

Specifically, Patch #1 used global functions
to facilitate pr_* macros in the header files so they are available in different C files.
Patch #2 removes the global function libbpf_print_level_available() which is added in Patch 1.
Patch #3 simplified libbpf_set_print() which takes only one print function with a debug level argument among others.

Changelogs:
v3 -> v4:
. rename libbpf internal header util.h to libbpf_util.h
. rename libbpf internal function libbpf_debug_print() to libbpf_print()
v2 -> v3:
. bailed out earlier in libbpf_debug_print() if __libbpf_pr is NULL . added missing LIBBPF_DEBUG level check in libbpf.c __base_pr().
v1 -> v2:
. Renamed global function libbpf_dprint() to libbpf_debug_print()
to be more expressive.
. Removed libbpf_dprint_level_available() as it is used only
once in btf.c and we can remove it by optimizing for common cases.

Yonghong Song (3):
tools/bpf: move libbpf pr_* debug print functions to headers tools/bpf: print out btf log at LIBBPF_WARN level tools/bpf: simplify libbpf API function libbpf_set_print()

 tools/lib/bpf/btf.c                           | 110 +++++++++---------
 tools/lib/bpf/btf.h                           |   7 +-
 tools/lib/bpf/libbpf.c                        |  47 ++++----
 tools/lib/bpf/libbpf.h                        |  20 ++--
 tools/lib/bpf/libbpf_util.h                   |  30 +++++
 tools/lib/bpf/test_libbpf.cpp                 |   4 +-
 tools/perf/util/bpf-loader.c                  |  32 ++---
 tools/testing/selftests/bpf/test_btf.c        |   7 +-
 .../testing/selftests/bpf/test_libbpf_open.c  |  36 +++---
 tools/testing/selftests/bpf/test_progs.c      |  20 +++-
 10 files changed, 171 insertions(+), 142 deletions(-)
 create mode 100644 tools/lib/bpf/libbpf_util.h
Signature · 1 line
2.17.1