Skip to content

RFC Get rid of switchdev_ops

Florian Fainelli linux-rdma lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest13 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GETinclude/net/switchdev.h+10 -01 reply
2/13rocker: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/rocker/rocker_main.c+24 -00 replies
3/13net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SETnet/dsa/slave.c+24 -00 replies
4/13mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c+23 -00 replies
5/13net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/mscc/ocelot.c+24 -00 replies
6/13staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/staging/fsl-dpaa2/ethsw/ethsw.c+24 -00 replies
7/13bnxt: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h+67 -30 replies
8/13liquidio: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/ethernet/cavium/liquidio/lio_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c+91 -21 reply
9/13mlxsw: switchx2: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/ethernet/mellanox/mlxsw/switchx2.c+42 -10 replies
10/13net/mlx5e: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/ethernet/mellanox/mlx5/core/en_rep.c drivers/net/ethernet/mellanox/mlx5/core/en_rep.h+48 -30 replies
11/13nfp: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/ethernet/netronome/nfp/nfp_main.c drivers/net/ethernet/netronome/nfp/nfp_net.h drivers/net/ethernet/netronome/nfp/nfp_net_common.c +2 more+52 -22 replies
12/13netdevsim: Handle SWITCHDEV_PORT_ATTR_GET eventdrivers/net/netdevsim/netdev.c+42 -10 replies
13/13net: switchdev: Replace port attr get/set SDO with a notificationdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c drivers/net/ethernet/cavium/liquidio/lio_main.c +17 more+37 -1870 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC net-next 00/13] Get rid of switchdev_ops

Hi all,

This patch series converts SWITCHDEV_PORT_ATTR_{GET,SET} to use a blocking notifier, similar to how SWITCHDEV_PORT_OBJ_{ADD,DEL} has been changed recently by Petr.

This was suggested by Ido to help with a particular use case I have where I want to be able to veto a switchdev bridge attribute from a driver (multicast_snooping).

Please review since I may not have gotten the driver abstraction right, especially for mlx5e and nfp since these are *hum* *hum* large drivers.

Florian Fainelli (13):
switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET
rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET
net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET
mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SET
net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SET
staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SET
bnxt: Handle SWITCHDEV_PORT_ATTR_GET event
liquidio: Handle SWITCHDEV_PORT_ATTR_GET event
mlxsw: switchx2: Handle SWITCHDEV_PORT_ATTR_GET event net/mlx5e: Handle SWITCHDEV_PORT_ATTR_GET event
nfp: Handle SWITCHDEV_PORT_ATTR_GET event
netdevsim: Handle SWITCHDEV_PORT_ATTR_GET event
net: switchdev: Replace port attr get/set SDO with a notification

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  63 ++++++++++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |   9 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.h |   8 ++
 .../net/ethernet/cavium/liquidio/lio_main.c   |  53 ++++++++-
 .../net/ethernet/cavium/liquidio/lio_vf_rep.c |  48 +++++++-
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   4 +-
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  50 ++++++--
 .../net/ethernet/mellanox/mlx5/core/en_rep.h  |   2 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  12 --
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |   2 -
 .../mellanox/mlxsw/spectrum_switchdev.c       |  36 +++---
 .../net/ethernet/mellanox/mlxsw/switchx2.c    |  46 +++++++-
 drivers/net/ethernet/mscc/ocelot.c            |  30 ++++-
 drivers/net/ethernet/netronome/nfp/nfp_main.c |  14 ++-
 drivers/net/ethernet/netronome/nfp/nfp_net.h  |   3 +
 .../ethernet/netronome/nfp/nfp_net_common.c   |  19 +++-
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |   2 -
 drivers/net/ethernet/netronome/nfp/nfp_port.c |  17 ++-
 drivers/net/ethernet/netronome/nfp/nfp_port.h |   5 +-
 drivers/net/ethernet/rocker/rocker_main.c     |  30 ++++-
 drivers/net/netdevsim/netdev.c                |  46 +++++++-
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c       |  30 ++++-
 include/linux/netdevice.h                     |   3 -
 include/net/switchdev.h                       |  28 ++---
 net/dsa/slave.c                               |  30 ++++-
 net/switchdev/switchdev.c                     | 107 ++++++------------
 26 files changed, 503 insertions(+), 194 deletions(-)
Signature · 1 line
2.17.1