Skip to content

trace-cmd protocol fixes

Slavomir Kaslev linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8trace-cmd: Remove unused global variabletracecmd/trace-msg.c+0 -20 replies
2/8trace-cmd: Rename error_operation_for_servertracecmd/trace-msg.c+9 -120 replies
3/8trace-cmd: Remove tracecmd_msg_handle/tracecmd_msg_server distinctioninclude/trace-cmd/trace-cmd.h tracecmd/trace-listen.c tracecmd/trace-msg.c +1 more+7 -390 replies
4/8trace-cmd: Check if connection is done when reading data in tracecmd_msg_read_datatracecmd/trace-msg.c+1 -10 replies
5/8trace-cmd: Fix a memory leak in tracecmd_msg_send_init_datatracecmd/trace-msg.c+23 -130 replies
6/8trace-cmd: Make tracecmd_msg_send_close return error code if anyinclude/trace-cmd/trace-cmd.h tracecmd/trace-msg.c+3 -34 replies
7/8trace-cmd: Add tracecmd_msg_wait_close functioninclude/trace-cmd/trace-cmd.h tracecmd/trace-msg.c+16 -200 replies
8/8trace-cmd: Acknowledge unexpected protocol messagestracecmd/trace-msg.c+41 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] trace-cmd protocol fixes

This patch set tries to make trace-cmd's protocol more robust to future changes. New MSG_NOT_SUPP message is added for acknowledgement of unexpected requests.

Slavomir Kaslev (8):
trace-cmd: Remove unused global variable
trace-cmd: Rename error_operation_for_server
trace-cmd: Remove tracecmd_msg_handle/tracecmd_msg_server distinction
trace-cmd: Check if connection is done when reading data in
tracecmd_msg_read_data
trace-cmd: Fix a memory leak in tracecmd_msg_send_init_data
trace-cmd: Make tracecmd_msg_send_close return error code if any
trace-cmd: Add tracecmd_msg_wait_close function
trace-cmd: Acknowledge unexpected protocol messages

 include/trace-cmd/trace-cmd.h |  14 +--
 tracecmd/trace-listen.c       |   2 +-
 tracecmd/trace-msg.c          | 172 ++++++++++++++++++----------------
 tracecmd/trace-record.c       |   2 +-
 4 files changed, 96 insertions(+), 94 deletions(-)
Signature · 1 line
2.19.1