Skip to content

perf tools: Move ipc_symbol computation to resort

Jiri Olsa lkml 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3perf tools: Add argument to hists__resort_cb_t callbacktools/perf/builtin-c2c.c tools/perf/util/hist.c tools/perf/util/hist.h+11 -100 replies
2/3perf tools: Add perf_evsel__output_resort_cb functiontools/perf/util/hist.c tools/perf/util/hist.h+10 -20 replies
3/3perf tools: Move symbol annotation to resorttools/perf/builtin-report.c tools/perf/util/sort.c+19 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] perf tools: Move ipc_symbol computation to resort

hi,
currently the we make annotation for ipc column during the entry display, already outside the progress bar scope, so it appears like perf report is stuck.

You can see that on following example (with perf.data big enough):

     $ perf record -b ...
     $ perf report -s symbol

The report TUI code will appear stuck when scrolling down, because annotation are computed at that time. For --stdio, the output will be displayed noticeably more slowly, than with the fix.

There's no functional change, I'm just moving the annotation retrieval to the resort phase, so all the data are ready for display.

thanks,
jirka

---
Jiri Olsa (3):
perf tools: Add argument to hists__resort_cb_t callback perf tools: Add perf_evsel__output_resort_cb function perf tools: Move symbol annotation to resort

 tools/perf/builtin-c2c.c    |  8 ++++----
 tools/perf/builtin-report.c | 21 +++++++++++++++++++--
 tools/perf/util/hist.c      | 19 +++++++++++++------
 tools/perf/util/hist.h      |  4 +++-
 tools/perf/util/sort.c      |  7 -------
 5 files changed, 39 insertions(+), 20 deletions(-)