perf tools: Move ipc_symbol computation to resort
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf tools: Add argument to hists__resort_cb_t callbacktools/ tools/ tools/ | +11 | 0 replies | |
| 2/3 | perf tools: Add perf_evsel__output_resort_cb functiontools/ tools/ | +10 | 0 replies | |
| 3/3 | perf tools: Move symbol annotation to resorttools/ tools/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] perf tools: Move ipc_symbol computation to resort
hi,
currently the we make annotation for ipc column during the entry display, already outside the progress bar scope, so it appears like perf report is stuck.
You can see that on following example (with perf.data big enough):
$ perf record -b ...
$ perf report -s symbolThe report TUI code will appear stuck when scrolling down, because annotation are computed at that time. For --stdio, the output will be displayed noticeably more slowly, than with the fix.
There's no functional change, I'm just moving the annotation retrieval to the resort phase, so all the data are ready for display.
thanks,
jirka
---
Jiri Olsa (3):
perf tools: Add argument to hists__resort_cb_t callback perf tools: Add perf_evsel__output_resort_cb function perf tools: Move symbol annotation to resort
tools/perf/builtin-c2c.c | 8 ++++---- tools/perf/builtin-report.c | 21 +++++++++++++++++++-- tools/perf/util/hist.c | 19 +++++++++++++------ tools/perf/util/hist.h | 4 +++- tools/perf/util/sort.c | 7 ------- 5 files changed, 39 insertions(+), 20 deletions(-)