Skip to content

powerpc/64s: tidy and gasify exception handler code, round 1

Nicholas Piggin linuxppc-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17powerpc/64s/exception: fix some line wrap and semicolon inconsistencies in macrosarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h+52 -520 replies
2/17powerpc/64s/exception: remove H concatenation for EXC_HV variantsarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+247 -1790 replies
3/17powerpc/64s/exception: consolidate EXCEPTION_PROLOG_2 with _NORI variantarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+14 -350 replies
4/17powerpc/64s/exception: move and tidy EXCEPTION_PROLOG_2 variantsarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+45 -480 replies
5/17powerpc/64s/exception: remove the "extra" macro parameterarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+107 -1160 replies
6/17powerpc/64s/exception: consolidate maskable and non-maskable prologsarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+49 -720 replies
7/17powerpc/64s/exception: merge KVM handler and skip variantsarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+15 -230 replies
8/17powerpc/64s/exception: KVM handler can set the HSRR trap bitarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h+7 -50 replies
9/17powerpc/64s/exception: Make EXCEPTION_PROLOG_0 a gas macro for consistency with othersarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+19 -180 replies
10/17powerpc/64s/exception: Move EXCEPTION_COMMON handler and return branches into callersarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+26 -210 replies
11/17powerpc/64s/exception: Move EXCEPTION_COMMON additions into callersarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+39 -520 replies
12/17powerpc/64s/exception: unwind exception-64s.h macrosarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+78 -1490 replies
13/17powerpc/64s/exception: move EXCEPTION_PROLOG_2* to a more logical placearch/powerpc/include/asm/exception-64s.h+57 -560 replies
14/17powerpc/64s/exception: remove STD_EXCEPTION_COMMON variantsarch/powerpc/include/asm/exception-64s.h arch/powerpc/include/asm/head-64.h+17 -240 replies
15/17powerpc/64s/exception: move KVM related code togetherarch/powerpc/include/asm/exception-64s.h+21 -190 replies
16/17powerpc/64s/exception: move exception-64s.h code to exception-64s.S where it is usedarch/powerpc/include/asm/exception-64s.h arch/powerpc/kernel/exceptions-64s.S+429 -4290 replies
17/17powerpc/64s/exception: move head-64.h code to exception-64s.S where it is usedarch/powerpc/include/asm/head-64.h arch/powerpc/kernel/exceptions-64s.S+251 -2520 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/17] powerpc/64s: tidy and gasify exception handler code, round 1

My previous big patch was received about as well as can be expected. That is to say I'll assume everybody loved it, so we have to get there a bit more incrementally.

This first round of patches was verified each patch (with several configs) to not change any generated code, to make a small step to improving things.

The end result is that head-64.h is only used for fixed section layout code, exeption-64s.h is only used for some paca layout and speculation control sequences, and exception-64s.S contains all the actual code for interrupt handlers in a bit nicer form.

There is quite a way to go yet, but hopefully this is a improvement already, and the good thing about generated code not changing with this series is that backports are easy to verify. Once we start code changes, we'll want to minimise the number of releases they are spread over.

Thanks,
Nick

Nicholas Piggin (17):
powerpc/64s/exception: fix some line wrap and semicolon
inconsistencies in macros
powerpc/64s/exception: remove H concatenation for EXC_HV variants powerpc/64s/exception: consolidate EXCEPTION_PROLOG_2 with _NORI
variant
powerpc/64s/exception: move and tidy EXCEPTION_PROLOG_2 variants powerpc/64s/exception: remove the "extra" macro parameter powerpc/64s/exception: consolidate maskable and non-maskable prologs powerpc/64s/exception: merge KVM handler and skip variants powerpc/64s/exception: KVM handler can set the HSRR trap bit powerpc/64s/exception: Make EXCEPTION_PROLOG_0 a gas macro for
consistency with others
powerpc/64s/exception: Move EXCEPTION_COMMON handler and return
branches into callers
powerpc/64s/exception: Move EXCEPTION_COMMON additions into callers powerpc/64s/exception: unwind exception-64s.h macros powerpc/64s/exception: move EXCEPTION_PROLOG_2* to a more logical
place
powerpc/64s/exception: remove STD_EXCEPTION_COMMON variants powerpc/64s/exception: move KVM related code together powerpc/64s/exception: move exception-64s.h code to exception-64s.S
where it is used
powerpc/64s/exception: move head-64.h code to exception-64s.S where it
is used

 arch/powerpc/include/asm/exception-64s.h | 585 +-------------
 arch/powerpc/include/asm/head-64.h       | 204 +----
 arch/powerpc/kernel/exceptions-64s.S     | 932 ++++++++++++++++++++---
 3 files changed, 822 insertions(+), 899 deletions(-)
Signature · 1 line
2.18.0