Skip to content

net: Introduce ndo_get_port_parent_id()

Florian Fainelli bridge linux-rdma lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 5 repliesIn review
  2. v312 patches 14 repliesSuperseded
  3. v212 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches5 repliesSuperseded

Changes in v4 from the cover letter

- remove superfluous net/switchdev.h inclusions in a few files
- added Jiri's Acked-by where given
- removed err = -EOPNOTSUPP initializations
- changed according to Jiri's suggestion in net/ipv4/ipmr.c

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net: Introduce ndo_get_port_parent_id()include/linux/netdevice.h net/bridge/br_switchdev.c net/core/dev.c +3 more+91 -51 reply
2/12bnxt: Implement ndo_get_port_parent_id()drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c +1 more+15 -310 replies
3/12liquidio: Implement ndo_get_port_parent_id()drivers/net/ethernet/cavium/liquidio/lio_main.c drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c+12 -350 replies
4/12net/mlx5e: Implement ndo_get_port_parent_id()drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c drivers/net/ethernet/mellanox/mlx5/core/en_rep.c drivers/net/ethernet/mellanox/mlx5/core/en_tc.c+14 -240 replies
5/12mlxsw: Implement ndo_get_port_parent_id()drivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c drivers/net/ethernet/mellanox/mlxsw/switchx2.c+26 -291 reply
6/12mscc: ocelot: Implement ndo_get_port_parent_id()drivers/net/ethernet/mscc/ocelot.c+13 -200 replies
7/12nfp: Implement ndo_get_port_parent_id()drivers/net/ethernet/netronome/nfp/flower/action.c drivers/net/ethernet/netronome/nfp/nfp_net_common.c drivers/net/ethernet/netronome/nfp/nfp_net_repr.c +2 more+11 -260 replies
8/12rocker: Implement ndo_get_port_parent_id()drivers/net/ethernet/rocker/rocker_main.c+13 -40 replies
9/12netdevsim: Implement ndo_get_port_parent_id()drivers/net/netdevsim/netdev.c+6 -170 replies
10/12staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()drivers/staging/fsl-dpaa2/ethsw/ethsw.c+12 -40 replies
11/12net: dsa: Implement ndo_get_port_parent_id()net/dsa/slave.c+12 -60 replies
12/12net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_IDinclude/net/switchdev.h net/bridge/br_switchdev.c net/core/net-sysfs.c +3 more+15 -841 reply

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoIdo Schimmel
1/12A-b R-b
2/12A-b
3/12A-b
4/12A-b
5/12A-b R-b
6/12A-b
7/12A-b
8/12A-b
9/12A-b
10/12
11/12A-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

Hi all,

Based on discussion with Ido and feedback from Jakub there are clearly two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID:

- PF/VF drivers which typically only implement return the port's parent ID, yet have to implement switchdev_port_attr_get() just for that

- Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more attributes which we want to be able to eventually veto in the context of the caller, thus making them candidates for using a blocking notifier chain

Changes in v4:

- remove superfluous net/switchdev.h inclusions in a few files
- added Jiri's Acked-by where given
- removed err = -EOPNOTSUPP initializations
- changed according to Jiri's suggestion in net/ipv4/ipmr.c

Changes in v3:

- keep ethsw's switchdev_ops assignment
- remove inclusion of net/switchdev.h in netdevsim which is no longer necesary

Changes in v2:

- resolved build failures spotted by kbuild test robot
- added helpers functions into the core network device layer:
dev_get_port_parent_id() and netdev_port_same_parent_id();
- added support for recursion to lower devices

Changes from RFC:

- introduce a ndo_get_port_parent_id() and convert all relevant drivers to use it

- get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID

A subsequent set of patches will convert switchdev_port_attr_set() to use a blocking notifier call, and still get rid of switchdev_port_attr_get() altogether.

Florian Fainelli (12):
net: Introduce ndo_get_port_parent_id()
bnxt: Implement ndo_get_port_parent_id()
liquidio: Implement ndo_get_port_parent_id() net/mlx5e: Implement ndo_get_port_parent_id()
mlxsw: Implement ndo_get_port_parent_id()
mscc: ocelot: Implement ndo_get_port_parent_id()
nfp: Implement ndo_get_port_parent_id()
rocker: Implement ndo_get_port_parent_id()
netdevsim: Implement ndo_get_port_parent_id()
staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()
net: dsa: Implement ndo_get_port_parent_id()
net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 28 +++------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  4 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c  |  2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 12 ++--
 .../net/ethernet/cavium/liquidio/lio_main.c   | 22 ++-----
 .../net/ethernet/cavium/liquidio/lio_vf_rep.c | 25 +++-----
 .../ethernet/mellanox/mlx5/core/en/tc_tun.c   |  2 +-
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  | 31 ++++------
 .../net/ethernet/mellanox/mlx5/core/en_tc.c   |  5 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 13 +++++
 .../mellanox/mlxsw/spectrum_switchdev.c       |  5 --
 .../net/ethernet/mellanox/mlxsw/switchx2.c    | 37 +++++-------
 drivers/net/ethernet/mscc/ocelot.c            | 33 +++++------
 .../ethernet/netronome/nfp/flower/action.c    |  3 +-
 .../ethernet/netronome/nfp/nfp_net_common.c   |  4 +-
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  4 +-
 drivers/net/ethernet/netronome/nfp/nfp_port.c | 22 ++-----
 drivers/net/ethernet/netronome/nfp/nfp_port.h |  4 +-
 drivers/net/ethernet/rocker/rocker_main.c     | 17 ++++--
 drivers/net/netdevsim/netdev.c                | 23 ++------
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c       | 16 ++++--
 include/linux/netdevice.h                     |  9 +++
 include/net/switchdev.h                       | 11 ----
 net/bridge/br_switchdev.c                     |  9 +--
 net/core/dev.c                                | 57 +++++++++++++++++++
 net/core/net-sysfs.c                          | 12 +---
 net/core/rtnetlink.c                          | 12 +---
 net/dsa/slave.c                               | 18 ++++--
 net/ipv4/ipmr.c                               | 13 ++---
 net/switchdev/switchdev.c                     | 20 -------
 30 files changed, 214 insertions(+), 259 deletions(-)
Signature · 1 line
2.17.1