net: Introduce ndo_get_port_parent_id()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest12 patches 5 repliesIn review
- v312 patches 14 repliesSuperseded
- v212 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 12 patches | 5 replies | Superseded |
Changes in v4 from the cover letter
- remove superfluous net/switchdev.h inclusions in a few files
- added Jiri's Acked-by where given
- removed err = -EOPNOTSUPP initializations
- changed according to Jiri's suggestion in net/ipv4/ipmr.c
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | net: Introduce ndo_get_port_parent_id()include/ net/ net/ +3 more | +91 | 1 reply | |
| 2/12 | bnxt: Implement ndo_get_port_parent_id()drivers/ drivers/ drivers/ +1 more | +15 | 0 replies | |
| 3/12 | liquidio: Implement ndo_get_port_parent_id()drivers/ drivers/ | +12 | 0 replies | |
| 4/12 | net/mlx5e: Implement ndo_get_port_parent_id()drivers/ drivers/ drivers/ | +14 | 0 replies | |
| 5/12 | mlxsw: Implement ndo_get_port_parent_id()drivers/ drivers/ drivers/ | +26 | 1 reply | |
| 6/12 | mscc: ocelot: Implement ndo_get_port_parent_id()drivers/ | +13 | 0 replies | |
| 7/12 | nfp: Implement ndo_get_port_parent_id()drivers/ drivers/ drivers/ +2 more | +11 | 0 replies | |
| 8/12 | rocker: Implement ndo_get_port_parent_id()drivers/ | +13 | 0 replies | |
| 9/12 | netdevsim: Implement ndo_get_port_parent_id()drivers/ | +6 | 0 replies | |
| 10/12 | staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()drivers/ | +12 | 0 replies | |
| 11/12 | net: dsa: Implement ndo_get_port_parent_id()net/ | +12 | 0 replies | |
| 12/12 | net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_IDinclude/ net/ net/ +3 more | +15 | 1 reply |
Reviews trailers per patch
11 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Pirko | Ido Schimmel |
|---|---|---|
| 1/12 | A-b | R-b |
| 2/12 | A-b | |
| 3/12 | A-b | |
| 4/12 | A-b | |
| 5/12 | A-b | R-b |
| 6/12 | A-b | |
| 7/12 | A-b | |
| 8/12 | A-b | |
| 9/12 | A-b | |
| 10/12 | ||
| 11/12 | A-b | |
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()
Hi all,
Based on discussion with Ido and feedback from Jakub there are clearly two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID:
- PF/VF drivers which typically only implement return the port's parent ID, yet have to implement switchdev_port_attr_get() just for that
- Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more attributes which we want to be able to eventually veto in the context of the caller, thus making them candidates for using a blocking notifier chain
Changes in v4:
- remove superfluous net/switchdev.h inclusions in a few files
- added Jiri's Acked-by where given
- removed err = -EOPNOTSUPP initializations
- changed according to Jiri's suggestion in net/ipv4/ipmr.c
Changes in v3:
- keep ethsw's switchdev_ops assignment
- remove inclusion of net/switchdev.h in netdevsim which is no longer necesary
Changes in v2:
- resolved build failures spotted by kbuild test robot
- added helpers functions into the core network device layer:
dev_get_port_parent_id() and netdev_port_same_parent_id();
- added support for recursion to lower devices
Changes from RFC:
- introduce a ndo_get_port_parent_id() and convert all relevant drivers to use it
- get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID
A subsequent set of patches will convert switchdev_port_attr_set() to use a blocking notifier call, and still get rid of switchdev_port_attr_get() altogether.
Florian Fainelli (12):
net: Introduce ndo_get_port_parent_id()
bnxt: Implement ndo_get_port_parent_id()
liquidio: Implement ndo_get_port_parent_id() net/mlx5e: Implement ndo_get_port_parent_id()
mlxsw: Implement ndo_get_port_parent_id()
mscc: ocelot: Implement ndo_get_port_parent_id()
nfp: Implement ndo_get_port_parent_id()
rocker: Implement ndo_get_port_parent_id()
netdevsim: Implement ndo_get_port_parent_id()
staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id()
net: dsa: Implement ndo_get_port_parent_id()
net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +++------ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 12 ++-- .../net/ethernet/cavium/liquidio/lio_main.c | 22 ++----- .../net/ethernet/cavium/liquidio/lio_vf_rep.c | 25 +++----- .../ethernet/mellanox/mlx5/core/en/tc_tun.c | 2 +- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 31 ++++------ .../net/ethernet/mellanox/mlx5/core/en_tc.c | 5 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 13 +++++ .../mellanox/mlxsw/spectrum_switchdev.c | 5 -- .../net/ethernet/mellanox/mlxsw/switchx2.c | 37 +++++------- drivers/net/ethernet/mscc/ocelot.c | 33 +++++------ .../ethernet/netronome/nfp/flower/action.c | 3 +- .../ethernet/netronome/nfp/nfp_net_common.c | 4 +- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 4 +- drivers/net/ethernet/netronome/nfp/nfp_port.c | 22 ++----- drivers/net/ethernet/netronome/nfp/nfp_port.h | 4 +- drivers/net/ethernet/rocker/rocker_main.c | 17 ++++-- drivers/net/netdevsim/netdev.c | 23 ++------ drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 16 ++++-- include/linux/netdevice.h | 9 +++ include/net/switchdev.h | 11 ---- net/bridge/br_switchdev.c | 9 +-- net/core/dev.c | 57 +++++++++++++++++++ net/core/net-sysfs.c | 12 +--- net/core/rtnetlink.c | 12 +--- net/dsa/slave.c | 18 ++++-- net/ipv4/ipmr.c | 13 ++--- net/switchdev/switchdev.c | 20 ------- 30 files changed, 214 insertions(+), 259 deletions(-)
Signature · 1 line
2.17.1