Skip to content

ARM: davinci: move the da8xx-ohci GPIO logic into the driver

Bartosz Golaszewski linux-arm-kernel linux-usb lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 1 replyIn review
  2. v18 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- use the non-sleeping version of gpiod_ functions in the irq handler
- improve commit messages (make them readable without the subject line)
- collect Acked-by and Reviewed-by tags
- rebase on top of v5.0-rc6

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8usb: ohci-da8xx: add a new line after local variablesdrivers/usb/host/ohci-da8xx.c+1 -00 replies
2/8usb: ohci-da8xx: add a helper pointer to &pdev->devdrivers/usb/host/ohci-da8xx.c+9 -90 replies
3/8ARM: davinci: omapl138-hawk: use gpio lookup entries for usb gpiosarch/arm/mach-davinci/board-omapl138-hawk.c+10 -00 replies
4/8ARM: davinci: da830-evm: use gpio lookup entries for usb gpiosarch/arm/mach-davinci/board-da830-evm.c+10 -00 replies
5/8usb: ohci-da8xx: add vbus and overcurrent gpiosdrivers/usb/host/ohci-da8xx.c+50 -491 reply
6/8ARM: davinci: omapl138-hawk: remove legacy usb helpersarch/arm/mach-davinci/board-omapl138-hawk.c+1 -740 replies
7/8ARM: davinci: da830-evm: remove legacy usb helpersarch/arm/mach-davinci/board-da830-evm.c+0 -670 replies
8/8usb: ohci-da8xx: remove unused callbacks from platform datainclude/linux/platform_data/usb-davinci.h+0 -140 replies

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchAlan SternLinus Walleij
1/8A-b
2/8A-b
3/8R-b
4/8R-b
5/8A-b
6/8
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] ARM: davinci: move the da8xx-ohci GPIO logic into the driver

From: Bartosz Golaszewski <[email protected]>

In order to drop the hard-coded GPIO base values from the davinci GPIO driver's platform data, we first need to get rid of all calls to the legacy GPIO functions.

This series moves the GPIO logic related to da8xx-ohci out of the board files and into the driver code.

First two patches are just coding style tweaks. Next two add the GPIO lookup entries to the board files. Patch 5 add the vbus and overcurrent GPIO logic to the davinci USB host driver. Last three remove code that's no longer used.

v1 -> v2:
- use the non-sleeping version of gpiod_ functions in the irq handler
- improve commit messages (make them readable without the subject line)
- collect Acked-by and Reviewed-by tags
- rebase on top of v5.0-rc6

Bartosz Golaszewski (8):
usb: ohci-da8xx: add a new line after local variables
usb: ohci-da8xx: add a helper pointer to &pdev->dev
ARM: davinci: omapl138-hawk: use gpio lookup entries for usb gpios
ARM: davinci: da830-evm: use gpio lookup entries for usb gpios
usb: ohci-da8xx: add vbus and overcurrent gpios
ARM: davinci: omapl138-hawk: remove legacy usb helpers
ARM: davinci: da830-evm: remove legacy usb helpers
usb: ohci-da8xx: remove unused callbacks from platform data

 arch/arm/mach-davinci/board-da830-evm.c     |  73 ++----------
 arch/arm/mach-davinci/board-omapl138-hawk.c |  81 ++------------
 drivers/usb/host/ohci-da8xx.c               | 118 ++++++++++----------
 include/linux/platform_data/usb-davinci.h   |  14 ---
 4 files changed, 77 insertions(+), 209 deletions(-)
Signature · 1 line
2.20.1