Skip to content

ALSA: Drop superfluous PCM preallocation error checks

Takashi Iwai alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20ALSA: atmel: Drop superfluous PCM preallocation error checkssound/atmel/ac97c.c+1 -30 replies
2/20ALSA: parisc: Drop superfluous PCM preallocation error checkssound/parisc/harmony.c+2 -80 replies
3/20ALSA: pci: Drop superfluous PCM preallocation error checkssound/pci/ad1889.c sound/pci/aw2/aw2-alsa.c sound/pci/bt87x.c +7 more+63 -1010 replies
4/20ALSA: ppc: Drop superfluous PCM preallocation error checkssound/ppc/snd_ps3.c+1 -50 replies
5/20ALSA: sh: Drop superfluous PCM preallocation error checkssound/sh/aica.c+6 -80 replies
6/20ALSA: sparc: Drop superfluous PCM preallocation error checkssound/sparc/dbri.c+3 -60 replies
7/20ALSA: spi: Drop superfluous PCM preallocation error checkssound/spi/at73c213.c+1 -10 replies
8/20ALSA: usb: Drop superfluous PCM preallocation error checkssound/usb/usx2y/usbusx2yaudio.c sound/usb/usx2y/usx2yhwdeppcm.c+18 -220 replies
9/20ASoC: amd: Drop superfluous PCM preallocation error checkssound/soc/amd/acp-pcm-dma.c sound/soc/amd/raven/acp3x-pcm-dma.c+15 -200 replies
10/20ASoC: dwc: Drop superfluous PCM preallocation error checkssound/soc/dwc/dwc-pcm.c+2 -10 replies
11/20ASoC: intel: Drop superfluous PCM preallocation error checkssound/soc/intel/atom/sst-mfld-platform-pcm.c sound/soc/intel/baytrail/sst-baytrail-pcm.c sound/soc/intel/haswell/sst-haswell-pcm.c +1 more+10 -330 replies
12/20ASoC: mediatek: Drop superfluous PCM preallocation error checkssound/soc/mediatek/common/mtk-afe-platform-driver.c+3 -30 replies
13/20ASoC: meson: Drop superfluous PCM preallocation error checkssound/soc/meson/axg-fifo.c+4 -30 replies
14/20ASoC: sh: Drop superfluous PCM preallocation error checkssound/soc/sh/fsi.c sound/soc/sh/rcar/core.c sound/soc/sh/siu_pcm.c+4 -171 reply
15/20ASoC: stm: Drop superfluous PCM preallocation error checkssound/soc/stm/stm32_adfsdm.c+3 -20 replies
16/20ASoC: txx9: Drop superfluous PCM preallocation error checkssound/soc/txx9/txx9aclc.c+3 -10 replies
17/20ASoC: uniphier: Drop superfluous PCM preallocation error checkssound/soc/uniphier/aio-dma.c+2 -10 replies
18/20ASoC: xtensa: Drop superfluous PCM preallocation error checkssound/soc/xtensa/xtfpga-i2s.c+3 -30 replies
19/20ASoC: dmaengine: Drop superfluous PCM preallocation error checkssound/soc/soc-generic-dmaengine-pcm.c+1 -40 replies
20/20ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning voidinclude/sound/pcm.h sound/core/pcm_memory.c+12 -250 replies

Reviews trailers per patch

1 of 20 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKuninori MorimotoJaroslav KyselaMark Brown
SeriesR-b A-b
1/20
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20A-b
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks

Hi,

this is yet another patchset for trivial cleanups.
At this time, it's about the superfluous error check from snd_pcm_lib_preallocate_pages() and co. They always succeed and never return a failure although many codes do the error check. The patches simply remove the error checks and finally change the function to be void function.

The patches are applied on top of my previous NULL device fix patches, so not applicable to ASoC tree, I guess. As all these are trivial, applying through my tree altogether would be simpler.

So, Mark, please give your ACK if the changes to ASoC drivers are OK.

thanks,

Takashi

===

Takashi Iwai (20):
ALSA: atmel: Drop superfluous PCM preallocation error checks
ALSA: parisc: Drop superfluous PCM preallocation error checks
ALSA: pci: Drop superfluous PCM preallocation error checks
ALSA: ppc: Drop superfluous PCM preallocation error checks
ALSA: sh: Drop superfluous PCM preallocation error checks
ALSA: sparc: Drop superfluous PCM preallocation error checks
ALSA: spi: Drop superfluous PCM preallocation error checks
ALSA: usb: Drop superfluous PCM preallocation error checks
ASoC: amd: Drop superfluous PCM preallocation error checks
ASoC: dwc: Drop superfluous PCM preallocation error checks
ASoC: intel: Drop superfluous PCM preallocation error checks
ASoC: mediatek: Drop superfluous PCM preallocation error checks
ASoC: meson: Drop superfluous PCM preallocation error checks
ASoC: sh: Drop superfluous PCM preallocation error checks
ASoC: stm: Drop superfluous PCM preallocation error checks
ASoC: txx9: Drop superfluous PCM preallocation error checks
ASoC: uniphier: Drop superfluous PCM preallocation error checks
ASoC: xtensa: Drop superfluous PCM preallocation error checks
ASoC: dmaengine: Drop superfluous PCM preallocation error checks
ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void

 include/sound/pcm.h                                |  8 ++---
 sound/atmel/ac97c.c                                |  4 +--
 sound/core/pcm_memory.c                            | 29 +++++-----------
 sound/parisc/harmony.c                             | 10 ++----
 sound/pci/ad1889.c                                 |  7 +---
 sound/pci/aw2/aw2-alsa.c                           | 40 +++++++---------------
 sound/pci/bt87x.c                                  | 10 +++---
 sound/pci/ca0106/ca0106_main.c                     | 16 ++++-----
 sound/pci/echoaudio/echoaudio.c                    | 16 ++++-----
 sound/pci/emu10k1/emupcm.c                         | 22 ++++++++----
 sound/pci/emu10k1/p16v.c                           | 17 ++++-----
 sound/pci/lx6464es/lx6464es.c                      |  8 ++---
 sound/pci/rme9652/hdspm.c                          | 20 +++--------
 sound/pci/via82xx_modem.c                          |  8 ++---
 sound/ppc/snd_ps3.c                                |  6 +---
 sound/sh/aica.c                                    | 14 ++++----
 sound/soc/amd/acp-pcm-dma.c                        | 26 ++++++--------
 sound/soc/amd/raven/acp3x-pcm-dma.c                |  9 +++--
 sound/soc/dwc/dwc-pcm.c                            |  3 +-
 sound/soc/intel/atom/sst-mfld-platform-pcm.c       |  9 ++---
 sound/soc/intel/baytrail/sst-baytrail-pcm.c        | 15 +++-----
 sound/soc/intel/haswell/sst-haswell-pcm.c          | 10 ++----
 sound/soc/intel/skylake/skl-pcm.c                  |  9 ++---
 .../soc/mediatek/common/mtk-afe-platform-driver.c  |  6 ++--
 sound/soc/meson/axg-fifo.c                         |  7 ++--
 sound/soc/sh/fsi.c                                 |  3 +-
 sound/soc/sh/rcar/core.c                           |  5 +--
 sound/soc/sh/siu_pcm.c                             | 13 +------
 sound/soc/soc-generic-dmaengine-pcm.c              |  5 +--
 sound/soc/stm/stm32_adfsdm.c                       |  5 +--
 sound/soc/txx9/txx9aclc.c                          |  4 ++-
 sound/soc/uniphier/aio-dma.c                       |  3 +-
 sound/soc/xtensa/xtfpga-i2s.c                      |  6 ++--
 sound/sparc/dbri.c                                 |  9 ++---
 sound/spi/at73c213.c                               |  2 +-
 sound/usb/usx2y/usbusx2yaudio.c                    | 21 ++++++------
 sound/usb/usx2y/usx2yhwdeppcm.c                    | 19 +++++-----
 37 files changed, 157 insertions(+), 267 deletions(-)
Signature · 1 line
2.16.4