ALSA: Drop superfluous PCM preallocation error checks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | ALSA: atmel: Drop superfluous PCM preallocation error checkssound/ | +1 | 0 replies | |
| 2/20 | ALSA: parisc: Drop superfluous PCM preallocation error checkssound/ | +2 | 0 replies | |
| 3/20 | ALSA: pci: Drop superfluous PCM preallocation error checkssound/ sound/ sound/ +7 more | +63 | 0 replies | |
| 4/20 | ALSA: ppc: Drop superfluous PCM preallocation error checkssound/ | +1 | 0 replies | |
| 5/20 | ALSA: sh: Drop superfluous PCM preallocation error checkssound/ | +6 | 0 replies | |
| 6/20 | ALSA: sparc: Drop superfluous PCM preallocation error checkssound/ | +3 | 0 replies | |
| 7/20 | ALSA: spi: Drop superfluous PCM preallocation error checkssound/ | +1 | 0 replies | |
| 8/20 | ALSA: usb: Drop superfluous PCM preallocation error checkssound/ sound/ | +18 | 0 replies | |
| 9/20 | ASoC: amd: Drop superfluous PCM preallocation error checkssound/ sound/ | +15 | 0 replies | |
| 10/20 | ASoC: dwc: Drop superfluous PCM preallocation error checkssound/ | +2 | 0 replies | |
| 11/20 | ASoC: intel: Drop superfluous PCM preallocation error checkssound/ sound/ sound/ +1 more | +10 | 0 replies | |
| 12/20 | ASoC: mediatek: Drop superfluous PCM preallocation error checkssound/ | +3 | 0 replies | |
| 13/20 | ASoC: meson: Drop superfluous PCM preallocation error checkssound/ | +4 | 0 replies | |
| 14/20 | ASoC: sh: Drop superfluous PCM preallocation error checkssound/ sound/ sound/ | +4 | 1 reply | |
| 15/20 | ASoC: stm: Drop superfluous PCM preallocation error checkssound/ | +3 | 0 replies | |
| 16/20 | ASoC: txx9: Drop superfluous PCM preallocation error checkssound/ | +3 | 0 replies | |
| 17/20 | ASoC: uniphier: Drop superfluous PCM preallocation error checkssound/ | +2 | 0 replies | |
| 18/20 | ASoC: xtensa: Drop superfluous PCM preallocation error checkssound/ | +3 | 0 replies | |
| 19/20 | ASoC: dmaengine: Drop superfluous PCM preallocation error checkssound/ | +1 | 0 replies | |
| 20/20 | ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning voidinclude/ sound/ | +12 | 0 replies |
Reviews trailers per patch
1 of 20 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kuninori Morimoto | Jaroslav Kysela | Mark Brown |
|---|---|---|---|
| Series | R-b | A-b | |
| 1/20 | |||
| 2/20 | |||
| 3/20 | |||
| 4/20 | |||
| 5/20 | |||
| 6/20 | |||
| 7/20 | |||
| 8/20 | |||
| 9/20 | |||
| 10/20 | |||
| 11/20 | |||
| 12/20 | |||
| 13/20 | |||
| 14/20 | A-b | ||
| 15/20 | |||
| 16/20 | |||
| 17/20 | |||
| 18/20 | |||
| 19/20 | |||
| 20/20 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/20] ALSA: Drop superfluous PCM preallocation error checks
Hi,
this is yet another patchset for trivial cleanups.
At this time, it's about the superfluous error check from snd_pcm_lib_preallocate_pages() and co. They always succeed and never return a failure although many codes do the error check. The patches simply remove the error checks and finally change the function to be void function.
The patches are applied on top of my previous NULL device fix patches, so not applicable to ASoC tree, I guess. As all these are trivial, applying through my tree altogether would be simpler.
So, Mark, please give your ACK if the changes to ASoC drivers are OK.
thanks,
Takashi
===
Takashi Iwai (20):
ALSA: atmel: Drop superfluous PCM preallocation error checks
ALSA: parisc: Drop superfluous PCM preallocation error checks
ALSA: pci: Drop superfluous PCM preallocation error checks
ALSA: ppc: Drop superfluous PCM preallocation error checks
ALSA: sh: Drop superfluous PCM preallocation error checks
ALSA: sparc: Drop superfluous PCM preallocation error checks
ALSA: spi: Drop superfluous PCM preallocation error checks
ALSA: usb: Drop superfluous PCM preallocation error checks
ASoC: amd: Drop superfluous PCM preallocation error checks
ASoC: dwc: Drop superfluous PCM preallocation error checks
ASoC: intel: Drop superfluous PCM preallocation error checks
ASoC: mediatek: Drop superfluous PCM preallocation error checks
ASoC: meson: Drop superfluous PCM preallocation error checks
ASoC: sh: Drop superfluous PCM preallocation error checks
ASoC: stm: Drop superfluous PCM preallocation error checks
ASoC: txx9: Drop superfluous PCM preallocation error checks
ASoC: uniphier: Drop superfluous PCM preallocation error checks
ASoC: xtensa: Drop superfluous PCM preallocation error checks
ASoC: dmaengine: Drop superfluous PCM preallocation error checks
ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning void
include/sound/pcm.h | 8 ++--- sound/atmel/ac97c.c | 4 +-- sound/core/pcm_memory.c | 29 +++++----------- sound/parisc/harmony.c | 10 ++---- sound/pci/ad1889.c | 7 +--- sound/pci/aw2/aw2-alsa.c | 40 +++++++--------------- sound/pci/bt87x.c | 10 +++--- sound/pci/ca0106/ca0106_main.c | 16 ++++----- sound/pci/echoaudio/echoaudio.c | 16 ++++----- sound/pci/emu10k1/emupcm.c | 22 ++++++++---- sound/pci/emu10k1/p16v.c | 17 ++++----- sound/pci/lx6464es/lx6464es.c | 8 ++--- sound/pci/rme9652/hdspm.c | 20 +++-------- sound/pci/via82xx_modem.c | 8 ++--- sound/ppc/snd_ps3.c | 6 +--- sound/sh/aica.c | 14 ++++---- sound/soc/amd/acp-pcm-dma.c | 26 ++++++-------- sound/soc/amd/raven/acp3x-pcm-dma.c | 9 +++-- sound/soc/dwc/dwc-pcm.c | 3 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 9 ++--- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 15 +++----- sound/soc/intel/haswell/sst-haswell-pcm.c | 10 ++---- sound/soc/intel/skylake/skl-pcm.c | 9 ++--- .../soc/mediatek/common/mtk-afe-platform-driver.c | 6 ++-- sound/soc/meson/axg-fifo.c | 7 ++-- sound/soc/sh/fsi.c | 3 +- sound/soc/sh/rcar/core.c | 5 +-- sound/soc/sh/siu_pcm.c | 13 +------ sound/soc/soc-generic-dmaengine-pcm.c | 5 +-- sound/soc/stm/stm32_adfsdm.c | 5 +-- sound/soc/txx9/txx9aclc.c | 4 ++- sound/soc/uniphier/aio-dma.c | 3 +- sound/soc/xtensa/xtfpga-i2s.c | 6 ++-- sound/sparc/dbri.c | 9 ++--- sound/spi/at73c213.c | 2 +- sound/usb/usx2y/usbusx2yaudio.c | 21 ++++++------ sound/usb/usx2y/usx2yhwdeppcm.c | 19 +++++----- 37 files changed, 157 insertions(+), 267 deletions(-)
Signature · 1 line
2.16.4