Skip to content

migration: Mark multifd not experimental

Juan Quintela qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 6 repliesIn review
  2. v28 patches 8 repliesSuperseded
  3. v14 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- answer all comments from Dave
- updates to latest upstream.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8multifd: Only send pages when packet are not emptymigration/ram.c+12 -60 replies
2/8multifd: Rename "size" member to pages_allocmigration/ram.c+12 -110 replies
3/8multifd: Create new next_packet_size fieldmigration/ram.c migration/trace-events+15 -44 replies
4/8multifd: Drop x-multifd-page-count parameterhmp.c migration/migration.c migration/migration.h +2 more+11 -551 reply
5/8multifd: Be flexible about packet sizemigration/ram.c+18 -60 replies
6/8multifd: Change default packet sizemigration/ram.c+1 -10 replies
7/8multifd: Drop x-hmp.c migration/migration.c qapi/migration.json+35 -351 reply
8/8tests: Add migration multifd testtests/migration-test.c+48 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertThomas HuthMarkus Armbruster
1/8R-b
2/8R-b
3/8R-b
4/8R-b A-b
5/8R-b
6/8R-b
7/8R-b A-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/8] migration: Mark multifd not experimental

v3:
- answer all comments from Dave
- updates to latest upstream.

v2:
- Measure packet size in bytes/not pages
- Change the defalut value from 64KB to 512KB
- rename used field to pages_used
- rename size field to pages_alloc
- Create nnext_packet_size field
Will be used on compression series later.
- Be flexible about what packet sizes we allow.

Please review,

In v1:

- Change page_count default to 128.

16 was really small, and it makes much less contention on mutexes to just have bigger packets.

- Drop multifd-page_count parameter

This parameter was useful for testing, but in all my testing 128 is good enough, no need to have an extra knob. Libvirt don't want to expose this parameter because it is difficult to explain.

- Drop experimental "x-" from multifd

Code is stable, nothing big is happening here.

- Multifd test

And a test for multifd, this test has already been on other patch series. But now it uses the names without "-x".

Please review.

Juan Quintela (8):
multifd: Only send pages when packet are not empty
multifd: Rename "size" member to pages_alloc
multifd: Create new next_packet_size field
multifd: Drop x-multifd-page-count parameter
multifd: Be flexible about packet size
multifd: Change default packet size
multifd: Drop x-
tests: Add migration multifd test

 hmp.c                  | 17 +++------
 migration/migration.c  | 56 +++++++-----------------------
 migration/migration.h  |  1 -
 migration/ram.c        | 79 ++++++++++++++++++++++++++++++------------
 migration/trace-events |  4 +--
 qapi/migration.json    | 45 +++++++++---------------
 tests/migration-test.c | 48 +++++++++++++++++++++++++
 7 files changed, 142 insertions(+), 108 deletions(-)
Signature · 1 line
2.20.1