Skip to content

4.4.174-stable review

Greg Kroah-Hartman linux-tegra lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest34 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34inet: frags: change inet_frags_init_net() return valueinclude/net/inet_frag.h net/ieee802154/6lowpan/reassembly.c net/ipv4/ip_fragment.c +2 more+37 -120 replies
2/34inet: frags: add a pointer to struct netns_fragsinclude/net/inet_frag.h include/net/ipv6.h net/ieee802154/6lowpan/reassembly.c +4 more+49 -410 replies
3/34inet: frags: refactor ipfrag_init()net/ipv4/ip_fragment.c+2 -20 replies
4/34inet: frags: refactor ipv6_frag_init()net/ipv6/reassembly.c+14 -120 replies
5/34inet: frags: refactor lowpan_net_frag_init()net/ieee802154/6lowpan/reassembly.c+11 -90 replies
6/34rhashtable: add rhashtable_lookup_get_insert_key()include/linux/rhashtable.h lib/rhashtable.c+64 -160 replies
7/34rhashtable: Add rhashtable_lookup()include/linux/rhashtable.h+52 -170 replies
8/34rhashtable: add schedule pointslib/rhashtable.c+4 -10 replies
9/34inet: frags: use rhashtables for reassembly unitsDocumentation/networking/ip-sysctl.txt include/net/inet_frag.h include/net/ipv6.h +6 more+267 -5760 replies
10/34net: ieee802154: 6lowpan: fix frag reassemblynet/ieee802154/6lowpan/6lowpan_i.h net/ieee802154/6lowpan/reassembly.c+9 -90 replies
11/34ipfrag: really prevent allocation on netns exitnet/ipv4/inet_fragment.c+1 -10 replies
12/34inet: frags: remove some helpersinclude/net/inet_frag.h include/net/ip.h include/net/ipv6.h +3 more+6 -230 replies
13/34inet: frags: get rif of inet_frag_evicting()include/net/inet_frag.h net/ipv4/ip_fragment.c net/ipv6/reassembly.c+32 -420 replies
14/34inet: frags: remove inet_frag_maybe_warn_overflow()include/net/inet_frag.h net/ieee802154/6lowpan/reassembly.c net/ipv4/inet_fragment.c +3 more+8 -250 replies
15/34inet: frags: break the 2GB limit for frags storageDocumentation/networking/ip-sysctl.txt include/net/inet_frag.h net/ieee802154/6lowpan/reassembly.c +5 more+32 -320 replies
16/34inet: frags: do not clone skb in ip_expire()net/ipv4/ip_fragment.c+6 -100 replies
17/34ipv6: frags: rewrite ip6_expire_frag_queue()net/ipv6/reassembly.c+16 -80 replies
18/34rhashtable: reorganize struct rhashtable layoutinclude/linux/rhashtable.h+2 -20 replies
19/34inet: frags: reorganize struct netns_fragsinclude/net/inet_frag.h+5 -40 replies
20/34inet: frags: get rid of ipfrag_skb_cb/FRAG_CBinclude/linux/skbuff.h+5 -00 replies
21/34inet: frags: fix ip6frag_low_thresh boundarynet/ieee802154/6lowpan/reassembly.c net/ipv4/ip_fragment.c net/ipv6/netfilter/nf_conntrack_reasm.c +1 more+17 -310 replies
22/34ip: discard IPv4 datagrams with overlapping segments.include/uapi/linux/snmp.h net/ipv4/ip_fragment.c net/ipv4/proc.c+22 -520 replies
23/34net: modify skb_rbtree_purge to return the truesize of all purged skbs.include/linux/skbuff.h net/core/skbuff.c+6 -20 replies
24/34ipv6: defrag: drop non-last frags smaller than min mtunet/ipv6/netfilter/nf_conntrack_reasm.c net/ipv6/reassembly.c+8 -00 replies
25/34net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friendsinclude/linux/skbuff.h net/core/skbuff.c+16 -30 replies
26/34ip: use rb trees for IP frag queue.include/linux/skbuff.h include/net/inet_frag.h net/ipv4/inet_fragment.c +3 more+116 -890 replies
27/34ip: add helpers to process in-order fragments faster.include/net/inet_frag.h net/ipv4/ip_fragment.c+79 -00 replies
28/34ip: process in-order fragments efficientlynet/ipv4/inet_fragment.c net/ipv4/ip_fragment.c+70 -420 replies
29/34ip: frags: fix crash in ip_do_fragment()net/ipv4/ip_fragment.c net/ipv6/netfilter/nf_conntrack_reasm.c+2 -00 replies
30/34ipv4: frags: precedence bug in ip_expire()net/ipv4/ip_fragment.c+1 -10 replies
31/34inet: frags: better deal with smp racesnet/ipv4/inet_fragment.c+15 -130 replies
32/34net: fix pskb_trim_rcsum_slow() with odd trim offsetnet/core/skbuff.c+3 -20 replies
33/34net: ipv4: do not handle duplicate fragments as overlappingnet/ipv4/ip_fragment.c+13 -70 replies
34/34rcu: Force boolean subscript for expedited stall warningskernel/rcu/tree.c+1 -10 replies

Reviews trailers per patch

5 of 34 patches have a Reviewed-by or Acked-by.

PatchHerbert XuStephen HemmingerEric Dumazet
1/34
2/34
3/34
4/34
5/34
6/34A-b
7/34
8/34A-b
9/34
10/34
11/34
12/34
13/34
14/34
15/34
16/34
17/34
18/34
19/34
20/34
21/34
22/34A-b
23/34
24/34
25/34
26/34
27/34
28/34
29/34R-b
30/34
31/34
32/34R-b
33/34
34/34

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 4.4 00/34] 4.4.174-stable review

This is the start of the stable review cycle for the 4.4.174 release. There are 34 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Sat Feb 9 11:30:10 UTC 2019. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.174-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.4.174-rc1

Paul E. McKenney <[email protected]>
rcu: Force boolean subscript for expedited stall warnings

Michal Kubecek <[email protected]>
net: ipv4: do not handle duplicate fragments as overlapping

Dimitris Michailidis <[email protected]>
net: fix pskb_trim_rcsum_slow() with odd trim offset

Eric Dumazet <[email protected]>
inet: frags: better deal with smp races

Dan Carpenter <[email protected]>
ipv4: frags: precedence bug in ip_expire()

Taehee Yoo <[email protected]>
ip: frags: fix crash in ip_do_fragment()

Peter Oskolkov <[email protected]>
ip: process in-order fragments efficiently

Peter Oskolkov <[email protected]>
ip: add helpers to process in-order fragments faster.

Peter Oskolkov <[email protected]>
ip: use rb trees for IP frag queue.

Eric Dumazet <[email protected]>
net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

Florian Westphal <[email protected]>
ipv6: defrag: drop non-last frags smaller than min mtu

Peter Oskolkov <[email protected]>
net: modify skb_rbtree_purge to return the truesize of all purged skbs.

Peter Oskolkov <[email protected]>
ip: discard IPv4 datagrams with overlapping segments.

Eric Dumazet <[email protected]>
inet: frags: fix ip6frag_low_thresh boundary

Eric Dumazet <[email protected]>
inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

Eric Dumazet <[email protected]>
inet: frags: reorganize struct netns_frags

Eric Dumazet <[email protected]>
rhashtable: reorganize struct rhashtable layout

Eric Dumazet <[email protected]>
ipv6: frags: rewrite ip6_expire_frag_queue()

Eric Dumazet <[email protected]>
inet: frags: do not clone skb in ip_expire()

Eric Dumazet <[email protected]>
inet: frags: break the 2GB limit for frags storage

Eric Dumazet <[email protected]>
inet: frags: remove inet_frag_maybe_warn_overflow()

Eric Dumazet <[email protected]>
inet: frags: get rif of inet_frag_evicting()

Eric Dumazet <[email protected]>
inet: frags: remove some helpers

Paolo Abeni <[email protected]>
ipfrag: really prevent allocation on netns exit

Alexander Aring <[email protected]>
net: ieee802154: 6lowpan: fix frag reassembly

Eric Dumazet <[email protected]>
inet: frags: use rhashtables for reassembly units

Eric Dumazet <[email protected]>
rhashtable: add schedule points

Ben Hutchings <[email protected]>
rhashtable: Add rhashtable_lookup()

Pablo Neira Ayuso <[email protected]>
rhashtable: add rhashtable_lookup_get_insert_key()

Eric Dumazet <[email protected]>
inet: frags: refactor lowpan_net_frag_init()

Eric Dumazet <[email protected]>
inet: frags: refactor ipv6_frag_init()

Eric Dumazet <[email protected]>
inet: frags: refactor ipfrag_init()

Eric Dumazet <[email protected]>
inet: frags: add a pointer to struct netns_frags

Eric Dumazet <[email protected]>
inet: frags: change inet_frags_init_net() return value

-------------

Diffstat:

 Documentation/networking/ip-sysctl.txt  |  13 +-
 Makefile                                |   4 +-
 include/linux/rhashtable.h              | 143 ++++++--
 include/linux/skbuff.h                  |  16 +-
 include/net/inet_frag.h                 | 133 ++++----
 include/net/ip.h                        |   1 -
 include/net/ipv6.h                      |  26 +-
 include/uapi/linux/snmp.h               |   1 +
 kernel/rcu/tree.c                       |   2 +-
 lib/rhashtable.c                        |  15 +-
 net/core/skbuff.c                       |  21 +-
 net/ieee802154/6lowpan/6lowpan_i.h      |  26 +-
 net/ieee802154/6lowpan/reassembly.c     | 148 ++++-----
 net/ipv4/inet_fragment.c                | 389 +++++-----------------
 net/ipv4/ip_fragment.c                  | 571 ++++++++++++++++++--------------
 net/ipv4/proc.c                         |   7 +-
 net/ipv6/netfilter/nf_conntrack_reasm.c | 100 +++---
 net/ipv6/proc.c                         |   5 +-
 net/ipv6/reassembly.c                   | 209 ++++++------
 19 files changed, 868 insertions(+), 962 deletions(-)