Skip to content

firmware_loader: few selftest fixes

Luis R. Rodriguez linux-fsdevel linux-wireless lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config"tools/testing/selftests/firmware/config+0 -10 replies
2/3Revert "selftests: firmware: remove use of non-standard diff -Z option"tools/testing/selftests/firmware/fw_filesystem.sh+6 -30 replies
3/3selftests: firmware: fix verify_reqs() return valuetools/testing/selftests/firmware/fw_lib.sh+1 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchShuah Khan
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] firmware_loader: few selftest fixes

From: Luis Chamberlain <[email protected]>

Greg,

I've found that Dan's patches really broke firmware testing. I've identified a proper fix for the issue he found, its the last patch. This series reverts his two patches which break testing, and fixes the issue he was running into. I leave it to him as exercise to add a busybox bash quirk for the bash issue he found with diff.

His patches are merged on v5.0-rc1 as such these should go to Linus tree as well. They are regressions on v5.0-rc1. Please let me know if there are any questions.

Luis

Luis Chamberlain (3):
Revert "selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK
to config"
Revert "selftests: firmware: remove use of non-standard diff -Z
option"
selftests: firmware: fix verify_reqs() return value

 tools/testing/selftests/firmware/config           | 1 -
 tools/testing/selftests/firmware/fw_filesystem.sh | 9 ++++++---
 tools/testing/selftests/firmware/fw_lib.sh        | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
2.18.0