multipath: fixes for invalid path device handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 1 replyIn review
- v14 patches 5 repliesSuperseded
Changes in v2 from the cover letter
use Martin Wilck's version of PATCH 1/4
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | multipathd: avoid null pointer dereference in LOG_MSGlibmultipath/ libmultipath/ multipathd/ | +10 | 0 replies | |
| 2/4 | multipath: blacklist zram deviceslibmultipath/ multipath/ | +2 | 0 replies | |
| 3/4 | multipathd: fix pp->initialized state ping-ponginglibmultipath/ libmultipath/ multipathd/ | +9 | 0 replies | |
| 4/4 | multipathd: don't resend change events for unknown deviceslibmultipath/ | +2 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Martin Wilck |
|---|---|
| Series | R-b |
| 1/4 | |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] multipath: fixes for invalid path device handling
I recently got a bug from a user with a bad property blacklist_exceptions line, where multipath tried to use a zram device, which caused multipathd to crash. This patch set fixes that crash, and then adds some additional safeguards to prevent things like this happening in the future.
The first patch fixes the crash. This crash could be triggered by any path device that isn't part of a multipath device, and has it's checker fail to check the path correctly.
The second patch blacklists zram devices specifically. The third patch fixes up some code weirdness that doesn't really cause any problems, aside from the messages it prints.
The fourth patch changes how pathinfo works so that it now drops devices of an unknown type if they can't get a wwid. The biggest reason to do this is so that multipath won't hold an open file descriptor for these devices, which are almost definitely not multipathable (and occasionally send them TUR ioctls, which are bound to fail, since they aren't scsi devices).
As an aside, is there a good reason why multipath uses a devnode blacklist to individually blacklist device types, instead of blacklisting all denodes, and adding exceptions for the device types that we do support?
Changes in v2:
use Martin Wilck's version of PATCH 1/4
Benjamin Marzinski (3):
multipath: blacklist zram devices
multipathd: fix pp->initialized state ping-ponging
multipathd: don't resend change events for unknown devices
Martin Wilck (1):
multipathd: avoid null pointer dereference in LOG_MSG
libmultipath/blacklist.c | 2 +- libmultipath/checkers.c | 9 +-------- libmultipath/checkers.h | 6 +++++- libmultipath/discovery.c | 10 +++++++--- libmultipath/structs.h | 1 + multipath/multipath.conf.5 | 2 +- multipathd/main.c | 10 +++++++--- 7 files changed, 23 insertions(+), 17 deletions(-)
Signature · 1 line
2.17.2