Skip to content

net: Remove switchdev_ops

Florian Fainelli bridge lkml netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 posting 2/28 patches 4 repliesIn review
  2. v2 posting 2/28 patches 5 repliesSuperseded
  3. v4 Latest9 patches 8 repliesIn review
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/29 patches11 repliesSuperseded
v2 posting 1/216 patches5 repliesSuperseded
v116 patches14 repliesSuperseded

Changes in v4 from the cover letter

- removed double space in Documentation/networking/switchdev.txt
- added Jiri's Acked-by tags
- added fall through annotations where appropriate

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Documentation: networking: switchdev: Update port parent ID sectionDocumentation/networking/switchdev.txt+5 -51 reply
2/9switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GETinclude/net/switchdev.h+10 -01 reply
3/9rocker: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/rocker/rocker_main.c+24 -00 replies
4/9mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c+23 -01 reply
5/9net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/net/ethernet/mscc/ocelot.c+21 -00 replies
6/9staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SETdrivers/staging/fsl-dpaa2/ethsw/ethsw.c+24 -00 replies
7/9net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SETnet/dsa/slave.c+24 -00 replies
8/9net: switchdev: Replace port attr get/set SDO with a notificationnet/switchdev/switchdev.c+37 -700 replies
9/9net: Remove switchdev_opsdrivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +6 more+0 -711 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoIdo Schimmel
1/9A-b R-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 0/9] net: Remove switchdev_ops

Hi all,

This patch series finishes by the removal of switchdev_ops. To get there we convert the existing switchdev_port_attr_{set,get} switchdev_ops to use a blocking notifier, thus making it consistent with how the objects are pushed to the switchdev enabled devices.

Please review and let me know what you think!

David, I would like to get Ido's feedback on this to make sure I did not miss something, thank you!

Changes in v4:
- removed double space in Documentation/networking/switchdev.txt
- added Jiri's Acked-by tags
- added fall through annotations where appropriate

Changes in v3:
- dropped patches removing te need to get the attribute since we still need that in order to support different sleeping vs. non-sleeping contexts

Changes in v2:
- fixed bisectability issues in patch #15
- added Acked-by from Jiri where necessary
- fixed a few minor issues according to Jiri's feedback:
- rename port_attr_event -> port_attr_set_event
- moved SWITCHDEV_PORT_ATTR_SET closer to other blocking events

Florian Fainelli (9):
Documentation: networking: switchdev: Update port parent ID section
switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET
rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET
mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SET
net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SET
staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SET
net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET
net: switchdev: Replace port attr get/set SDO with a notification
net: Remove switchdev_ops

 Documentation/networking/switchdev.txt        |  10 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  12 --
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |   2 -
 .../mellanox/mlxsw/spectrum_switchdev.c       |  36 +++---
 drivers/net/ethernet/mscc/ocelot.c            |  26 ++++-
 drivers/net/ethernet/rocker/rocker_main.c     |  30 ++++-
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c       |  30 ++++-
 include/linux/netdevice.h                     |   3 -
 include/net/switchdev.h                       |  28 ++---
 net/dsa/slave.c                               |  30 ++++-
 net/switchdev/switchdev.c                     | 107 ++++++------------
 11 files changed, 168 insertions(+), 146 deletions(-)
Signature · 1 line
2.17.1