kernel-shark: Add sched_waking event for sched plugin processing
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | kernel-shark: Remove testing of "success" field of wakeup eventskernel-shark/ kernel-shark/ | +3 | 0 replies | |
| 2/4 | kernel-shark: Consolidate duplicate code of the sched_wakeup eventskernel-shark/ | +66 | 3 replies | |
| 3/4 | kernel-shark: Remove plugin_get_rec_wakeup_pid()kernel-shark/ | +0 | 0 replies | |
| 4/4 | kernel-shark: Add sched_waking event processing to sched_wakingkernel-shark/ kernel-shark/ | +12 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Steven Rostedt (VMware) | Yordan Karadzhov |
|---|---|---|
| 1/4 | ||
| 2/4 | R-b | |
| 3/4 | ||
| 4/4 | Signen-off-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] kernel-shark: Add sched_waking event for sched plugin processing
Hi Yordan,
I was using kernel shark to examine vsock events, and noticed that when I only enabled sched_waking events, it did not give me the wake up boxes in the task plots. I decided to look at the code and modify it to handle it.
When doing that, I noticed that the "success" field of the event was being used. This is an obsolete field that will hopefully someday be removed. So I added a patch to remove that. I also did not want to just add cut and paste code to add the sched_waking, and instead made helper functions to process the events all the same. And finally, I added the sched_waking code.
Can you review these patches and if they are fine by you, give your "Reviewed-by" tag. Otherwise let me know if there's an issue that I should fix.
Thanks!
-- Steve
Tag SHA1: 746c45bb20a4c860d36c48d279286c67202248a0 Head SHA1: 746c45bb20a4c860d36c48d279286c67202248a0
Steven Rostedt (VMware) (4):
kernel-shark: Remove testing of "success" field of wakeup events
kernel-shark: Consolidate duplicate code of the sched_wakeup events
kernel-shark: Remove plugin_get_rec_wakeup_pid()
kernel-shark: Add sched_waking event processing to sched_waking
----
kernel-shark/src/plugins/sched_events.c | 147 +++++++++++++++----------------- kernel-shark/src/plugins/sched_events.h | 12 ++- 2 files changed, 76 insertions(+), 83 deletions(-)