Skip to content

dirty-bitmaps: deprecate @status field

John Snow qemu-devel 3 versions – Applied

Status from this message: Pushed to my bitmaps branch with the following minor changes:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 24 repliesApplied
  2. v26 patches 17 repliesSuperseded
  3. v15 patches 13 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10block/dirty-bitmap: add recording and busy propertiesblock/dirty-bitmap.c qapi/block-core.json qemu-deprecated.texi +1 more+52 -14 replies
2/10block/dirty-bitmaps: rename frozen predicate helperblock/dirty-bitmap.c include/block/dirty-bitmap.h migration/block-dirty-bitmap.c+19 -173 replies
3/10block/dirty-bitmap: remove set/reset assertions against enabled bitblock/dirty-bitmap.c+0 -22 replies
4/10block/dirty-bitmap: change semantics of enabled predicateblock/dirty-bitmap.c+7 -22 replies
5/10nbd: change error checking order for bitmapsnbd/server.c+5 -52 replies
6/10block/dirty-bitmap: explicitly lock bitmaps with successorsblock/dirty-bitmap.c+6 -51 reply
7/10block/dirty-bitmaps: unify qmp_locked and user_locked callsblock/dirty-bitmap.c blockdev.c include/block/dirty-bitmap.h +2 more+34 -413 replies
8/10block/dirty-bitmaps: move comment blockblock/dirty-bitmap.c+19 -172 replies
9/10blockdev: remove unused paio parameter documentationblockdev.c+0 -12 replies
10/10iotests: add busy/recording bit test to 124tests/qemu-iotests/124 tests/qemu-iotests/124.out+112 -22 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchEric BlakeVladimir Sementsov-Ogievskiy
1/10R-b R-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

The current internal meanings of "locked", "user_locked", "qmp_locked", "frozen", "enabled", and "disabled" are all a little muddled.

Deprecate the @status field in favor of two new booleans that carry very specific meanings. Then, rename and rework some of the internal semantics to help make the API a bit more clear and easier to read.

Well, in my opinion.

Based on my current bitmaps branch.

V3:

[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/10:[0002] [FC] 'block/dirty-bitmap: add recording and busy properties' 002/10:[0002] [FC] 'block/dirty-bitmaps: rename frozen predicate helper' 003/10:[down] 'block/dirty-bitmap: remove set/reset assertions against enabled bit' 004/10:[0006] [FC] 'block/dirty-bitmap: change semantics of enabled predicate' 005/10:[down] 'nbd: change error checking order for bitmaps' 006/10:[0002] [FC] 'block/dirty-bitmap: explicitly lock bitmaps with successors' 007/10:[0011] [FC] 'block/dirty-bitmaps: unify qmp_locked and user_locked calls' 008/10:[0002] [FC] 'block/dirty-bitmaps: move comment block' 009/10:[down] 'blockdev: remove unused paio parameter documentation' 010/10:[down] 'iotests: add busy/recording bit test to 124'

V3: (Following Vladimir's feedback)

001: Changed texi phrasing, parameter --> field
002: Commit message adjustment

     comment edit: "not locked" --> "not user_locked"

003: pulled forward out of patch 004
004: Commit message rewrite
create_successor and abdicate doc adjustments
005: New.
006: Change successor doc comment
Commit message adjustment
007: BdrvDirtyBitmap struct comment adjustments
Comment change to create_successor (lock --> busy) Incidental changes from 004's changes
008: Grammar fix (Eric)
009: New, trivial, unrelated fix tagging along. 010: iotest 124 added.

John Snow (10):
block/dirty-bitmap: add recording and busy properties block/dirty-bitmaps: rename frozen predicate helper block/dirty-bitmap: remove set/reset assertions against enabled bit block/dirty-bitmap: change semantics of enabled predicate
nbd: change error checking order for bitmaps block/dirty-bitmap: explicitly lock bitmaps with successors block/dirty-bitmaps: unify qmp_locked and user_locked calls block/dirty-bitmaps: move comment block
blockdev: remove unused paio parameter documentation
iotests: add busy/recording bit test to 124

 block/dirty-bitmap.c           | 111 ++++++++++++++++++---------------
 blockdev.c                     |  19 +++---
 include/block/dirty-bitmap.h   |   7 +--
 migration/block-dirty-bitmap.c |   8 +--
 nbd/server.c                   |  14 ++---
 qapi/block-core.json           |  10 ++-
 qemu-deprecated.texi           |   6 ++
 tests/qemu-iotests/124         | 110 ++++++++++++++++++++++++++++++++
 tests/qemu-iotests/124.out     |   4 +-
 tests/qemu-iotests/236.out     |  28 +++++++++
 10 files changed, 239 insertions(+), 78 deletions(-)
Signature · 1 line
2.17.2