Skip to content

Adjust the padding size for KASLR

Masayoshi Mizuma lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 0 repliesNew
  2. v54 patches 13 repliesSuperseded
  3. v44 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v35 patches8 repliesSuperseded
v21 patch3 repliesSuperseded

Changelog from the cover letter

v6: - Add documents to top of calc_direct_mapping_size() to
explain why the size of direct mapping area is configured as boot_params.max_addr (0004 patch).
- Add Acked-by from Baoquan (0004 patch).

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/boot: Wrap up the SRAT traversing code into subtable_parse()arch/x86/boot/compressed/acpi.c+14 -70 replies
2/4x86/boot: Add max_addr field in struct boot_paramsDocumentation/x86/zero-page.rst arch/x86/include/uapi/asm/bootparam.h+5 -10 replies
3/4x86/boot: Get the max address from SRATarch/x86/boot/compressed/acpi.c+27 -60 replies
4/4x86/mm/KASLR: Adjust the padding size for the direct mapping.arch/x86/mm/kaslr.c+48 -150 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBaoquan He
1/4R-b
2/4R-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] Adjust the padding size for KASLR

From: Masayoshi Mizuma <[email protected]>

The system sometimes crashes while memory hot-adding on KASLR enabled system. The crash happens because the regions pointed by kaslr_regions[].base are overwritten by the hot-added memory.

It happens because of the padding size for kaslr_regions[].base isn't enough for the system whose physical memory layout has huge space for memory hotplug. kaslr_regions[].base points "actual installed memory size + padding" or higher address. So, if the "actual + padding" is lower address than the maximum memory address, which means the memory address reachable by memory hot-add, kaslr_regions[].base is destroyed by the overwritten.

address
^
|------- maximum memory address (Hotplug)
| ^
|------- kaslr_regions[0].base | Hotadd-able region
| ^ |
| | padding |
| V V
|------- actual memory address (Installed on boot) |

Fix it by getting the maximum memory address from SRAT and store the value in boot_param, then set the padding size while KASLR initializing if the default padding size isn't enough.

Changelog:
v6: - Add documents to top of calc_direct_mapping_size() to
explain why the size of direct mapping area is configured as boot_params.max_addr (0004 patch).
- Add Acked-by from Baoquan (0004 patch).

Masayoshi Mizuma (4):
x86/boot: Wrap up the SRAT traversing code into subtable_parse() x86/boot: Add max_addr field in struct boot_params x86/boot: Get the max address from SRAT
x86/mm/KASLR: Adjust the padding size for the direct mapping.

 Documentation/x86/zero-page.rst       |  4 ++
 arch/x86/boot/compressed/acpi.c       | 42 +++++++++++++++---
 arch/x86/include/uapi/asm/bootparam.h |  2 +-
 arch/x86/mm/kaslr.c                   | 63 ++++++++++++++++++++-------
 4 files changed, 88 insertions(+), 23 deletions(-)
Signature · 1 line
2.20.1