Skip to content

genirq/affinity: add .calc_sets for improving IRQ allocation & spread

Ming Lei linux-block linux-nvme linux-pci lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesIn review
  2. v35 patches 18 repliesSuperseded
  3. v24 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- re-writen changelogs by Thomas Gleixner
- merge patch of removing 'const' into the patch for adding new callback

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4genirq/affinity: store interrupt sets size in 'struct irq_affinity'drivers/nvme/host/pci.c include/linux/interrupt.h kernel/irq/affinity.c+18 -82 replies
2/4genirq/affinity: add new callback for caculating interrupt sets sizedrivers/pci/msi.c include/linux/interrupt.h include/linux/pci.h +1 more+28 -252 replies
3/4nvme-pci: Simplify interrupt allocationdrivers/nvme/host/pci.c+16 -461 reply
4/4PCI: Document .calc_sets as required in case of multiple interrupt setsdrivers/pci/msi.c include/linux/interrupt.h+10 -70 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJens AxboeKeith BuschBjorn Helgaas
1/4R-b
2/4R-b A-b
3/4R-b R-b
4/4R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH V4 0/4] genirq/affinity: add .calc_sets for improving IRQ allocation & spread

Hi,

Currently pre-caculated set vectors are provided by driver for allocating & spread vectors. This way only works when drivers passes same 'max_vecs' and 'min_vecs' to pci_alloc_irq_vectors_affinity(), also requires driver to retry the allocating & spread.

As Bjorn and Keith mentioned, the current usage & interface for irq sets is a bit awkward because the retrying should have been avoided by providing one resonable 'min_vecs'. However, if 'min_vecs' isn't same with 'max_vecs', number of the allocated vectors is unknown before calling pci_alloc_irq_vectors_affinity(), then each set's vectors can't be pre-caculated.

Add a new callback of .calc_sets into 'struct irq_affinity' so that driver can caculate set vectors after IRQ vector is allocated and before spread IRQ vectors.

V4:
- re-writen changelogs by Thomas Gleixner
- merge patch of removing 'const' into the patch for adding new callback

V3:
- don't mark 'affd' as const in related functions
- add sanity check on affd->nr_sets
- remove the local variable of 'nr_sets' in irq_create_affinity_masks
- set .nr_sets as 2 in nvme
- update comment in msi.c

V2:
- add .calc_sets instead of .setup_affinity() which is easy to be abused by drivers

Ming Lei (4):
genirq/affinity: store interrupt sets size in 'struct irq_affinity' genirq/affinity: add new callback for caculating interrupt sets size
nvme-pci: Simplify interrupt allocation
PCI: Document .calc_sets as required in case of multiple interrupt
sets

 drivers/nvme/host/pci.c   | 63 ++++++++++++-----------------------------------
 drivers/pci/msi.c         | 32 +++++++++++++-----------
 include/linux/interrupt.h | 13 +++++++---
 include/linux/pci.h       |  4 +--
 kernel/irq/affinity.c     | 26 ++++++++++++-------
 5 files changed, 62 insertions(+), 76 deletions(-)
Signature · 1 line
2.9.5