Skip to content

RFC numa, spapr: add thread-id in the possible_cpus list

Laurent Vivier qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4numa, spapr: add thread-id in the possible_cpus listhw/ppc/spapr.c+13 -204 replies
2/4numa: exit on incomplete CPU mappinghw/core/machine.c tests/numa-test.c+21 -450 replies
3/4numa: move cpu_slot_to_string() upper in the functionhw/core/machine.c+22 -220 replies
4/4numa: check threads of the same core are on the same nodehw/core/machine.c tests/numa-test.c+26 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC 0/4] numa, spapr: add thread-id in the possible_cpus list

There are inconsistencies between the command line using "-numa node,cpus=XX" and what is checked internally:
the XX is supposed to be a CPU number, but for SPAPR it's taken as a core number, ignoring the threads. (See the description message of PATCH 1 for more details)

This series fixes this problem by introducing the threads in the possible_cpus list instead of only the cores. To avoid inconsistent topology, it doesn't allow anymore to have an incomplete CPU NUMA config on the command line (there was already a message announcing it will be absoleted for 2 years).

Laurent Vivier (4):
numa,spapr: add thread-id in the possible_cpus list
numa: exit on incomplete CPU mapping
numa: move cpu_slot_to_string() upper in the function
numa: check threads of the same core are on the same node

 hw/core/machine.c | 115 ++++++++++++++++++++++++++--------------------
 hw/ppc/spapr.c    |  33 ++++++-------
 tests/numa-test.c |  24 +---------
 3 files changed, 81 insertions(+), 91 deletions(-)
Signature · 1 line
2.20.1