Skip to content

configs: rk3288: Tinker Board SPL file must fit into 32 KiB

Tom Rini u-boot 6 versions – New

Get series with b4
b4 am 20190422192916.GQ4664@bill-the-cat

Versions newest first · linked by author and title

  1. v4 Latest posting 3/34 patches 0 repliesNew
  2. v4 posting 2/30 of 4 patches 0 repliesSuperseded
  3. v4 posting 1/30 of 4 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch0 repliesSuperseded
v21 patch0 repliesSuperseded
v1 RFC1 patch0 repliesSuperseded

Patches in v4 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Makefile: reusable function for BOARD_SIZE_CHECK+0 -00 replies
2/4imx: move BOARD_SIZE_CHECK to main Makefile+0 -00 replies
3/4configs: define CONFIG_SPL_SIZE_LIMIT+0 -01 reply
3/4configs: define CONFIG_SPL_SIZE_LIMIT+0 -00 replies
4/4configs: rk3288: Tinker Board SPL file must fit into 32 KiB+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [U-Boot] [PATCH v4 0/4] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
Quoted 28 lines · Simon Goldschmidt

Am 22.04.2019 um 16:36 schrieb Tom Rini:

Quoted 27 lines · Simon Goldschmidt
Quoted 25 lines

Heinrich,

Quoted 10 lines · Heinrich Schuchardt

The SPL image for the Tinker Board has to fit into 32 KiB. This includes up to 2 KiB for the file header.

A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define the board specific limit.

A common Makefile function is used for this test and the test against CONFIG_BOARD_SIZE_LIMIT.

Move the board size check from arch/arm/mach-imx/Makefile to Makefile.

Has anything from this series been applied? I now have a working patch that applies on top of this and adds a full SPL SRAM size check (including HEAP, GD and stack; via a host tool) which works for socfpga (as an example of a platform where SPL binary is loaded to limited SRAM).

Actually, my patch would replace your patch 3/4 but build on 1/4 (2/4 and 4/4 are arch-specific).

How should we proceed here? I could send a series including your 1/4, or I could send a series completely building on this series, at the downside of more or less reverting your 2/4.

Quoted 7 lines
Quoted 3 lines

What I would like to see is i.MX (and rockchip) converted to use your new test as well (also, yay! Thanks for following up on that!) and we drop the existing check here.

Ok, so while I cannot really help on i.MX and rockchip, why don't you accept this series from Heinrich and I'll send my patch as followup? Then we can discuss this with i.MX and rockchip maintainers.

Can you post your series now, and we can move from there? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190422/41964e3e/attachment.sig>