net: Get rid of switchdev_port_attr_get()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest posting 2/28 patches 12 repliesIn review
- v3 posting 1/29 patches 1 replySuperseded
- v29 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 9 patches | 6 replies | Superseded |
Changes in v3 from the cover letter
- rebased against net-next/master after Russell's IPv6 changes to DSA
- ignore prepare/commit phase for PRE_BRIDGE_FLAGS since we don't want to trigger the WARN() in net/switchdev/switchdev.c in the commit phase
Patches in v3 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | net: switchdev: Add PORT_PRE_BRIDGE_FLAGSinclude/ | +2 | 2 replies | |
| 2/8 | mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGSdrivers/ | +16 | 2 replies | |
| 3/8 | staging: fsl-dpaa2: ethsw: Handle PORT_PRE_BRIDGE_FLAGSdrivers/ | +14 | 1 reply | |
| 4/8 | net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGSnet/ net/ net/ | +18 | 1 reply | |
| 5/8 | rocker: Check Handle PORT_PRE_BRIDGE_FLAGSdrivers/ | +41 | 1 reply | |
| 6/8 | net: bridge: Stop calling switchdev_port_attr_get()net/ | +5 | 2 replies | |
| 7/8 | net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORTDocumentation/ drivers/ drivers/ +3 more | +6 | 1 reply | |
| 8/8 | net: Get rid of switchdev_port_attr_get()Documentation/ drivers/ drivers/ +3 more | +1 | 2 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Ido Schimmel | Jiri Pirko |
|---|---|---|
| 1/8 | R-b | A-b |
| 2/8 | R-b | A-b |
| 3/8 | A-b | |
| 4/8 | A-b | |
| 5/8 | A-b | |
| 6/8 | R-b | A-b |
| 7/8 | R-b | A-b |
| 8/8 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/8] net: Get rid of switchdev_port_attr_get()
Hi all,
This patch series splits the removal of the switchdev_ops that was proposed a few times before and first tackles the easy part which is the removal of the single call to switchdev_port_attr_get() within the bridge code.
As suggestd by Ido, this patch series adds a SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS which is used in the same context as the caller of switchdev_port_attr_set(), so not deferred, and then the operation is carried out in deferred context with setting a support bridge port flag.
Follow-up patches will do the switchdev_ops removal after introducing the proper helpers for the switchdev blocking notifier to work across stacked devices (unlike the previous submissions).
David this does depend on Russell's "[PATCH net-next v5 0/3] net: dsa:
mv88e6xxx: fix IPv6".
Changes in v3:
- rebased against net-next/master after Russell's IPv6 changes to DSA
- ignore prepare/commit phase for PRE_BRIDGE_FLAGS since we don't want to trigger the WARN() in net/switchdev/switchdev.c in the commit phase
Changes in v2:
- differentiate callers not supporting switchdev_port_attr_set() from the driver not being able to support specific bridge flags
- pass "mask" instead of "flags" for the PRE_BRIDGE_FLAGS check
- skip prepare phase for PRE_BRIDGE_FLAGS
- corrected documentation a bit more
- tested bridge_vlan_aware.sh with veth/VRF
Florian Fainelli (8):
net: switchdev: Add PORT_PRE_BRIDGE_FLAGS
mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGS
staging: fsl-dpaa2: ethsw: Handle PORT_PRE_BRIDGE_FLAGS
net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
rocker: Check Handle PORT_PRE_BRIDGE_FLAGS
net: bridge: Stop calling switchdev_port_attr_get()
net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT
net: Get rid of switchdev_port_attr_get()
Documentation/networking/switchdev.txt | 6 +- .../mellanox/mlxsw/spectrum_switchdev.c | 32 ++++---- drivers/net/ethernet/rocker/rocker_main.c | 74 ++++++++++--------- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 29 ++++---- include/net/switchdev.h | 13 +--- net/bridge/br_switchdev.c | 11 ++- net/dsa/dsa_priv.h | 2 + net/dsa/port.c | 12 +++ net/dsa/slave.c | 25 +------ 9 files changed, 98 insertions(+), 106 deletions(-)
Signature · 1 line
2.17.1