bitmaps: add inconsistent bit
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 32 repliesIn review
- v24 patches 17 repliesSuperseded
- v1 RFC2 patches 9 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | block/dirty-bitmaps: add inconsistent bitblock/ include/ qapi/ | +30 | 6 replies | |
| 2/7 | block/dirty-bitmap: add inconsistent statusblock/ qapi/ | +12 | 2 replies | |
| 3/7 | block/dirty-bitmaps: add block_dirty_bitmap_check functionblock/ blockdev.c include/ +2 more | +54 | 6 replies | |
| 4/7 | block/dirty-bitmaps: prohibit readonly bitmaps for backupsblockdev.c | +2 | 2 replies | |
| 5/7 | block/dirty-bitmaps: prohibit removing readonly bitmapsblockdev.c | +2 | 2 replies | |
| 6/7 | block/dirty-bitmaps: disallow busy bitmaps as merge sourceblock/ | +3 | 8 replies | |
| 7/7 | block/dirty-bitmaps: implement inconsistent bitblock/ | +53 | 5 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/7 | R-b | R-b |
| 2/7 | R-b | R-b |
| 3/7 | R-b | R-b |
| 4/7 | R-b | R-b |
| 5/7 | R-b | R-b |
| 6/7 | R-b | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/7] bitmaps: add inconsistent bit
Allow QEMU to read in bitmaps that have the in-use bit set, for the purposes of allowing users to delete those bitmaps.
This is chosen in preference to a hard error on load to minimize impact for a non-critical error, but to force the user or management utility to acknowledge that the bitmap is no longer viable.
1. Changed wording of meaning of persistent bit, inconsistent bit Declining to optimize to avoid allocations for this revision.
2. Add Reviewed-by from Eric.
3. Split into several patches that are more single-purpose, which highlights the individual fixes more clearly;
- Prohibit BUSY or INCONSISTENT bitmaps from being merge sources.
4. Declining feedback to prohibit disabling or enabling readonly bitmaps, on the basis that users may wish to enable/disable them prior to remounting their backing storage RW.
Decided to prohibit attempting to remove readonly bitmaps, so the failure happens earlier.
Prohibit sync=incremental backups using readonly bitmaps, because they're not capable of clearing the bitmap on success. sync=differential would be acceptable here. (Good spot, Vladimir.)
John Snow (7):
block/dirty-bitmaps: add inconsistent bit block/dirty-bitmap: add inconsistent status block/dirty-bitmaps: add block_dirty_bitmap_check function block/dirty-bitmaps: prohibit readonly bitmaps for backups block/dirty-bitmaps: prohibit removing readonly bitmaps block/dirty-bitmaps: disallow busy bitmaps as merge source block/dirty-bitmaps: implement inconsistent bit
qapi/block-core.json | 20 +++++-- include/block/dirty-bitmap.h | 15 ++++- block/dirty-bitmap.c | 63 +++++++++++++++++--- block/qcow2-bitmap.c | 103 +++++++++++++++++---------------- blockdev.c | 50 ++++------------ migration/block-dirty-bitmap.c | 12 +--- nbd/server.c | 3 +- 7 files changed, 151 insertions(+), 115 deletions(-)
Signature · 1 line
2.17.2