Skip to content

dropping more unused function parameters

Jeff King git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10diff: drop options parameter from diffcore_fix_diff_index()diff-lib.c diff.c diff.h+3 -30 replies
2/10diff: drop unused color reset parametersdiff.c+8 -130 replies
3/10diff: drop unused emit data parameter from sane_truncate_line()diff.c+2 -20 replies
4/10diff: drop complete_rewrite parameter from run_external_diff()diff.c+1 -30 replies
5/10merge-recursive: drop several unused parametersmerge-recursive.c+7 -120 replies
6/10pack-objects: drop unused parameter from oe_map_new_pack()pack-objects.c pack-objects.h+4 -50 replies
7/10files-backend: drop refs parameter from split_symref_update()refs/files-backend.c+2 -30 replies
8/10ref-filter: drop unused buf/sz pairsref-filter.c+4 -40 replies
9/10ref-filter: drop unused "obj" parametersref-filter.c+7 -70 replies
10/10ref-filter: drop unused "sz" parametersref-filter.c+14 -140 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchElijah Newren
1/10
2/10
3/10
4/10
5/10Helped-by
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/10] dropping more unused function parameters

Here are ten more patches from my exploration of -Wunused-parameters. Most of these are quite old and not urgent, but things seem relatively quiet now, and they all merge cleanly with "pu".

In a sense they should all be trivial to review, as they only remove unused parameters. But the thing to consider is whether that parameter's lack of use is actually a bug, or if it's simply cruft (and I argue in each case in favor of cruft).

[01/10]: diff: drop options parameter from diffcore_fix_diff_index() [02/10]: diff: drop unused color reset parameters
[03/10]: diff: drop unused emit data parameter from sane_truncate_line() [04/10]: diff: drop complete_rewrite parameter from run_external_diff() [05/10]: merge-recursive: drop several unused parameters [06/10]: pack-objects: drop unused parameter from oe_map_new_pack() [07/10]: files-backend: drop refs parameter from split_symref_update() [08/10]: ref-filter: drop unused buf/sz pairs
[09/10]: ref-filter: drop unused "obj" parameters
[10/10]: ref-filter: drop unused "sz" parameters

 diff-lib.c           |  2 +-
 diff.c               | 31 ++++++++++++-------------------
 diff.h               |  2 +-
 merge-recursive.c    | 19 +++++++------------
 pack-objects.c       |  3 +--
 pack-objects.h       |  6 +++---
 ref-filter.c         | 36 ++++++++++++++++++------------------
 refs/files-backend.c |  5 ++---
 8 files changed, 45 insertions(+), 59 deletions(-)

-Peff