Skip to content

Introduce memory region concept (including device local memory)

Matthew Auld dri-devel intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest37 patches 30 repliesIn review
  2. v237 patches 47 repliesSuperseded
  3. v1 RFC42 patches 52 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/37drm/i915: buddy allocatordrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/i915_buddy.c drivers/gpu/drm/i915/i915_buddy.h +4 more+1282 -00 replies
2/37drm/i915: introduce intel_memory_regiondrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_region.c +11 more+722 -01 reply
3/37drm/i915/region: support basic evictiondrivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_region.c drivers/gpu/drm/i915/gem/i915_gem_region.h +5 more+187 -42 replies
4/37drm/i915/region: support continuous allocationsdrivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/gem/i915_gem_region.c drivers/gpu/drm/i915/gem/i915_gem_region.h +2 more+166 -82 replies
5/37drm/i915/region: support volatile objectsdrivers/gpu/drm/i915/gem/i915_gem_internal.c drivers/gpu/drm/i915/gem/i915_gem_object.h drivers/gpu/drm/i915/gem/i915_gem_object_types.h +5 more+91 -212 replies
6/37drm/i915: Add memory region information to device_infodrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_device_info.h+4 -01 reply
7/37drm/i915: support creating LMEM objectsdrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h +5 more+166 -01 reply
8/37drm/i915: setup io-mapping for LMEMdrivers/gpu/drm/i915/intel_region_lmem.c+26 -20 replies
9/37drm/i915/lmem: support kernel mappingdrivers/gpu/drm/i915/gem/i915_gem_internal.c drivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h +6 more+152 -80 replies
10/37drm/i915/blt: don't assume pinned intel_contextdrivers/gpu/drm/i915/gem/i915_gem_client_blt.c drivers/gpu/drm/i915/gem/i915_gem_object_blt.c+4 -20 replies
11/37drm/i915/blt: bump size restrictiondrivers/gpu/drm/i915/gem/i915_gem_client_blt.c drivers/gpu/drm/i915/gem/i915_gem_object_blt.c drivers/gpu/drm/i915/gem/i915_gem_object_blt.h +2 more+170 -470 replies
12/37drm/i915/blt: support copying objectsdrivers/gpu/drm/i915/gem/i915_gem_object_blt.c drivers/gpu/drm/i915/gem/i915_gem_object_blt.h drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c +2 more+326 -31 reply
13/37drm/i915/selftests: move gpu-write-dw into utilsdrivers/gpu/drm/i915/gem/selftests/huge_pages.c drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c +1 more+169 -2361 reply
14/37drm/i915/selftests: add write-dword test for LMEMdrivers/gpu/drm/i915/selftests/intel_memory_region.c+179 -00 replies
15/37drm/i915/selftest: extend coverage to include LMEM huge-pagesdrivers/gpu/drm/i915/gem/selftests/huge_pages.c+120 -10 replies
16/37drm/i915/lmem: support CPU relocationsdrivers/gpu/drm/i915/gem/i915_gem_execbuffer.c+51 -41 reply
17/37drm/i915/lmem: support preaddrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/i915_gem.c+96 -00 replies
18/37drm/i915/lmem: support pwritedrivers/gpu/drm/i915/gem/i915_gem_lmem.c+87 -00 replies
19/37drm/i915: enumerate and init each supported regiondrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/selftests/mock_gem_device.c+72 -71 reply
20/37drm/i915: treat shmem as a regiondrivers/gpu/drm/i915/gem/i915_gem_phys.c drivers/gpu/drm/i915/gem/i915_gem_region.c drivers/gpu/drm/i915/gem/i915_gem_shmem.c +6 more+99 -490 replies
21/37drm/i915: treat stolen as a regiondrivers/gpu/drm/i915/gem/i915_gem_region.c drivers/gpu/drm/i915/gem/i915_gem_stolen.c drivers/gpu/drm/i915/gem/i915_gem_stolen.h +2 more+68 -240 replies
22/37drm/i915: define HAS_MAPPABLE_APERTUREdrivers/gpu/drm/i915/i915_drv.h+2 -00 replies
23/37drm/i915: do not map aperture if it is not available.drivers/gpu/drm/i915/i915_gem_gtt.c+22 -141 reply
24/37drm/i915: set num_fence_regs to 0 if there is no aperturedrivers/gpu/drm/i915/i915_gem_fence_reg.c+4 -22 replies
25/37drm/i915/selftests: check for missing aperturedrivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c drivers/gpu/drm/i915/gt/selftest_hangcheck.c +2 more+23 -50 replies
26/37drm/i915: error capture with no ggtt slotdrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_gpu_error.c+63 -201 reply
27/37drm/i915: Don't try to place HWS in non-existing mappable regiondrivers/gpu/drm/i915/gt/intel_engine_cs.c+1 -11 reply
28/37drm/i915: check for missing aperture in insert_mappable_nodedrivers/gpu/drm/i915/i915_gem.c+3 -01 reply
29/37drm/i915: Allow i915 to manage the vma offset nodes instead of drm coredrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gem/i915_gem_object.c drivers/gpu/drm/i915/gem/i915_gem_object.h +6 more+244 -361 reply
30/37drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSETdrivers/gpu/drm/i915/gem/i915_gem_ioctls.h drivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gem/i915_gem_object_types.h +3 more+68 -11 reply
31/37drm/i915/lmem: add helper to get CPU accessible offsetdrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h+19 -00 replies
32/37drm/i915: Add cpu and lmem fault handlersdrivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/gem/i915_gem_lmem.h drivers/gpu/drm/i915/gem/i915_gem_mman.c +2 more+201 -151 reply
33/37drm/i915: cpu-map based dumb buffersdrivers/gpu/drm/i915/gem/i915_gem_mman.c drivers/gpu/drm/i915/gem/i915_gem_object_types.h drivers/gpu/drm/i915/i915_drv.c +1 more+20 -31 reply
34/37drm/i915: support basic object migrationdrivers/gpu/drm/i915/gem/i915_gem_object.c drivers/gpu/drm/i915/gem/i915_gem_object.h drivers/gpu/drm/i915/gem/i915_gem_pages.c +1 more+278 -11 reply
35/37drm/i915: Introduce GEM_OBJECT_SETPARAM with I915_PARAM_MEMORY_REGIONdrivers/gpu/drm/i915/gem/i915_gem_context.c drivers/gpu/drm/i915/gem/i915_gem_context.h drivers/gpu/drm/i915/gem/i915_gem_ioctls.h +3 more+160 -12 replies
36/37drm/i915/query: Expose memory regions through the query uAPIdrivers/gpu/drm/i915/i915_query.c include/uapi/drm/i915_drm.h+96 -01 reply
37/37HAX drm/i915: add the fake lmem regionarch/x86/kernel/early-quirks.c drivers/gpu/drm/i915/gem/i915_gem_lmem.c drivers/gpu/drm/i915/i915_drv.c +5 more+121 -00 replies

Reviews trailers per patch

2 of 37 patches have a Reviewed-by or Acked-by.

PatchChris Wilson
1/37
2/37
3/37
4/37
5/37R-b
6/37
7/37
8/37
9/37
10/37
11/37
12/37
13/37R-b
14/37
15/37
16/37
17/37
18/37
19/37
20/37
21/37
22/37
23/37
24/37
25/37
26/37
27/37
28/37
29/37
30/37
31/37
32/37
33/37
34/37
35/37
36/37
37/37

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/37] Introduce memory region concept (including device local memory)

In preparation for upcoming devices with device local memory, introduce the concept of different memory regions, and a simple buddy allocator to manage them in i915.

One of the concerns raised from v1 was around not using enough of TTM, which is a fair criticism, so trying to get better alignment here is something we are investigating, though currently that is still WIP so in the meantime v3 still continues to push more of the low-level details forward, but not yet the TTM interactions.

Sidenote:
Daniel raised a fair point with the whole mmap_offset uAPI and whether we can just get away with using gtt_mmap, it looks like it should work and would simplify a few things and possibly allow us to drop a couple patches. Thoughts?

Abdiel Janulgue (11):
drm/i915: Add memory region information to device_info drm/i915: setup io-mapping for LMEM
drm/i915/lmem: support kernel mapping
drm/i915: enumerate and init each supported region drm/i915: Allow i915 to manage the vma offset nodes instead of drm
core
drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET drm/i915/lmem: add helper to get CPU accessible offset drm/i915: Add cpu and lmem fault handlers
drm/i915: cpu-map based dumb buffers
drm/i915: Introduce GEM_OBJECT_SETPARAM with I915_PARAM_MEMORY_REGION drm/i915/query: Expose memory regions through the query uAPI

CQ Tang (1):
drm/i915: check for missing aperture in insert_mappable_node

Daniele Ceraolo Spurio (4):
drm/i915: define HAS_MAPPABLE_APERTURE
drm/i915: do not map aperture if it is not available. drm/i915: set num_fence_regs to 0 if there is no aperture drm/i915: error capture with no ggtt slot

Matthew Auld (20):
drm/i915: buddy allocator
drm/i915: introduce intel_memory_region drm/i915/region: support basic eviction drm/i915/region: support continuous allocations drm/i915/region: support volatile objects
drm/i915: support creating LMEM objects drm/i915/blt: don't assume pinned intel_context drm/i915/blt: bump size restriction
drm/i915/blt: support copying objects drm/i915/selftests: move gpu-write-dw into utils drm/i915/selftests: add write-dword test for LMEM drm/i915/selftest: extend coverage to include LMEM huge-pages drm/i915/lmem: support CPU relocations drm/i915/lmem: support pread
drm/i915/lmem: support pwrite
drm/i915: treat shmem as a region
drm/i915: treat stolen as a region drm/i915/selftests: check for missing aperture drm/i915: support basic object migration
HAX drm/i915: add the fake lmem region

Michal Wajdeczko (1):
drm/i915: Don't try to place HWS in non-existing mappable region

 arch/x86/kernel/early-quirks.c                |  26 +
 drivers/gpu/drm/i915/Makefile                 |   5 +
 .../gpu/drm/i915/gem/i915_gem_client_blt.c    |  34 +-
 drivers/gpu/drm/i915/gem/i915_gem_context.c   |  17 +
 drivers/gpu/drm/i915/gem/i915_gem_context.h   |   2 +
 .../gpu/drm/i915/gem/i915_gem_execbuffer.c    |  55 +-
 drivers/gpu/drm/i915/gem/i915_gem_internal.c  |  21 +-
 drivers/gpu/drm/i915/gem/i915_gem_ioctls.h    |   4 +
 drivers/gpu/drm/i915/gem/i915_gem_lmem.c      | 315 +++++++
 drivers/gpu/drm/i915/gem/i915_gem_lmem.h      |  37 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      | 376 +++++++-
 drivers/gpu/drm/i915/gem/i915_gem_object.c    | 271 ++++++
 drivers/gpu/drm/i915/gem/i915_gem_object.h    |  29 +-
 .../gpu/drm/i915/gem/i915_gem_object_blt.c    | 349 +++++++-
 .../gpu/drm/i915/gem/i915_gem_object_blt.h    |  18 +-
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |  48 +-
 drivers/gpu/drm/i915/gem/i915_gem_pages.c     |  28 +-
 drivers/gpu/drm/i915/gem/i915_gem_phys.c      |   6 +-
 drivers/gpu/drm/i915/gem/i915_gem_region.c    | 165 ++++
 drivers/gpu/drm/i915/gem/i915_gem_region.h    |  29 +
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c     |  71 +-
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c    |  71 +-
 drivers/gpu/drm/i915/gem/i915_gem_stolen.h    |   3 +-
 .../drm/i915/gem/selftests/huge_gem_object.c  |   4 +-
 .../gpu/drm/i915/gem/selftests/huge_pages.c   | 331 ++++---
 .../i915/gem/selftests/i915_gem_client_blt.c  |  16 +-
 .../i915/gem/selftests/i915_gem_coherency.c   |   5 +-
 .../drm/i915/gem/selftests/i915_gem_context.c | 134 +--
 .../drm/i915/gem/selftests/i915_gem_mman.c    |  15 +-
 .../i915/gem/selftests/i915_gem_object_blt.c  | 128 ++-
 .../drm/i915/gem/selftests/igt_gem_utils.c    | 135 +++
 .../drm/i915/gem/selftests/igt_gem_utils.h    |  16 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   2 +-
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h  |   5 +-
 drivers/gpu/drm/i915/gt/intel_reset.c         |  13 +-
 drivers/gpu/drm/i915/gt/intel_ringbuffer.c    |   2 +-
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c  |  14 +-
 drivers/gpu/drm/i915/i915_buddy.c             | 433 ++++++++++
 drivers/gpu/drm/i915/i915_buddy.h             | 128 +++
 drivers/gpu/drm/i915/i915_drv.c               |  28 +-
 drivers/gpu/drm/i915/i915_drv.h               |  20 +-
 drivers/gpu/drm/i915/i915_gem.c               |  41 +-
 drivers/gpu/drm/i915/i915_gem_fence_reg.c     |   6 +-
 drivers/gpu/drm/i915/i915_gem_gtt.c           | 121 ++-
 drivers/gpu/drm/i915/i915_getparam.c          |   1 +
 drivers/gpu/drm/i915/i915_globals.c           |   1 +
 drivers/gpu/drm/i915/i915_globals.h           |   1 +
 drivers/gpu/drm/i915/i915_gpu_error.c         |  64 +-
 drivers/gpu/drm/i915/i915_pci.c               |  29 +-
 drivers/gpu/drm/i915/i915_query.c             |  57 ++
 drivers/gpu/drm/i915/i915_vma.c               |  21 +-
 drivers/gpu/drm/i915/intel_device_info.h      |   2 +
 drivers/gpu/drm/i915/intel_memory_region.c    | 240 +++++
 drivers/gpu/drm/i915/intel_memory_region.h    | 116 +++
 drivers/gpu/drm/i915/intel_region_lmem.c      | 141 +++
 drivers/gpu/drm/i915/intel_region_lmem.h      |  16 +
 drivers/gpu/drm/i915/selftests/i915_buddy.c   | 719 +++++++++++++++
 drivers/gpu/drm/i915/selftests/i915_gem.c     |   3 +
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c |   8 +-
 .../drm/i915/selftests/i915_live_selftests.h  |   1 +
 .../drm/i915/selftests/i915_mock_selftests.h  |   2 +
 .../drm/i915/selftests/intel_memory_region.c  | 817 ++++++++++++++++++
 .../gpu/drm/i915/selftests/mock_gem_device.c  |   9 +-
 drivers/gpu/drm/i915/selftests/mock_region.c  |  64 ++
 drivers/gpu/drm/i915/selftests/mock_region.h  |  16 +
 include/drm/i915_drm.h                        |   3 +
 include/uapi/drm/i915_drm.h                   |  93 ++
 67 files changed, 5524 insertions(+), 477 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_lmem.c
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_lmem.h
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_region.c
 create mode 100644 drivers/gpu/drm/i915/gem/i915_gem_region.h
 create mode 100644 drivers/gpu/drm/i915/i915_buddy.c
 create mode 100644 drivers/gpu/drm/i915/i915_buddy.h
 create mode 100644 drivers/gpu/drm/i915/intel_memory_region.c
 create mode 100644 drivers/gpu/drm/i915/intel_memory_region.h
 create mode 100644 drivers/gpu/drm/i915/intel_region_lmem.c
 create mode 100644 drivers/gpu/drm/i915/intel_region_lmem.h
 create mode 100644 drivers/gpu/drm/i915/selftests/i915_buddy.c
 create mode 100644 drivers/gpu/drm/i915/selftests/intel_memory_region.c
 create mode 100644 drivers/gpu/drm/i915/selftests/mock_region.c
 create mode 100644 drivers/gpu/drm/i915/selftests/mock_region.h
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel