Skip to content

ccid-card-passthru: check buffer size parameter

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest9 patches 15 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ccid-card-passthru: Move assertion in read() to can_read()hw/usb/ccid-card-passthru.c+2 -33 replies
2/9ccid-card-passthru: Replace never trigger if statement by an assertionhw/usb/ccid-card-passthru.c+1 -134 replies
3/9ccid-card-passthru: Assert on a stricter expressionhw/usb/ccid-card-passthru.c+1 -12 replies
4/9ccid-card-passthru: Let the chardev::read() be more generichw/usb/ccid-card-passthru.c+8 -21 reply
5/9ccid-card-passthru: Replace assert() by QEMU_BUILD_BUG_ON()hw/usb/ccid-card-passthru.c+5 -41 reply
6/9ccid-card-passthru: Simplify the if() conditionhw/usb/ccid-card-passthru.c+8 -101 reply
7/9ccid-card-passthru: Use QERR_MISSING_PARAMETERhw/usb/ccid-card-passthru.c+2 -11 reply
8/9ccid-card-passthru: Use size_t to hold size argumenthw/usb/ccid-card-passthru.c+6 -51 reply
9/9ccid-card-passthru: Use size_t for indexhw/usb/ccid-card-passthru.c+4 -31 reply

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchMarc-André Lureau
1/9R-b
2/9
3/9
4/9
5/9R-b
6/9R-b
7/9
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/9] ccid-card-passthru: check buffer size parameter

Hi,

This is the v2 of Prasad J Pandit first version [*], with Paolo's review comment addressed.
This is a quick fix for CVE-2018-18438: "Integer overflow in ccid_card_vscard_read() allows memory corruption".

Please review,

Phil.

[*] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02200.html

Philippe Mathieu-Daudé (9):
ccid-card-passthru: Move assertion in read() to can_read()
ccid-card-passthru: Replace never trigger if statement by an assertion
ccid-card-passthru: Assert on a stricter expression
ccid-card-passthru: Let the chardev::read() be more generic
ccid-card-passthru: Replace assert() by QEMU_BUILD_BUG_ON()
ccid-card-passthru: Simplify the if() condition
ccid-card-passthru: Use QERR_MISSING_PARAMETER
ccid-card-passthru: Use size_t to hold size argument
ccid-card-passthru: Use size_t for index

 hw/usb/ccid-card-passthru.c | 73 +++++++++++++++++--------------------
 1 file changed, 34 insertions(+), 39 deletions(-)
Signature · 1 line
2.20.1