ccid-card-passthru: check buffer size parameter
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest9 patches 15 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | ccid-card-passthru: Move assertion in read() to can_read()hw/ | +2 | 3 replies | |
| 2/9 | ccid-card-passthru: Replace never trigger if statement by an assertionhw/ | +1 | 4 replies | |
| 3/9 | ccid-card-passthru: Assert on a stricter expressionhw/ | +1 | 2 replies | |
| 4/9 | ccid-card-passthru: Let the chardev::read() be more generichw/ | +8 | 1 reply | |
| 5/9 | ccid-card-passthru: Replace assert() by QEMU_BUILD_BUG_ON()hw/ | +5 | 1 reply | |
| 6/9 | ccid-card-passthru: Simplify the if() conditionhw/ | +8 | 1 reply | |
| 7/9 | ccid-card-passthru: Use QERR_MISSING_PARAMETERhw/ | +2 | 1 reply | |
| 8/9 | ccid-card-passthru: Use size_t to hold size argumenthw/ | +6 | 1 reply | |
| 9/9 | ccid-card-passthru: Use size_t for indexhw/ | +4 | 1 reply |
Reviews trailers per patch
5 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Marc-André Lureau |
|---|---|
| 1/9 | R-b |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | R-b |
| 6/9 | R-b |
| 7/9 | |
| 8/9 | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/9] ccid-card-passthru: check buffer size parameter
Hi,
This is the v2 of Prasad J Pandit first version [*], with Paolo's review comment addressed.
This is a quick fix for CVE-2018-18438: "Integer overflow in ccid_card_vscard_read() allows memory corruption".
Please review,
Phil.
[*] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02200.html
Philippe Mathieu-Daudé (9):
ccid-card-passthru: Move assertion in read() to can_read()
ccid-card-passthru: Replace never trigger if statement by an assertion
ccid-card-passthru: Assert on a stricter expression
ccid-card-passthru: Let the chardev::read() be more generic
ccid-card-passthru: Replace assert() by QEMU_BUILD_BUG_ON()
ccid-card-passthru: Simplify the if() condition
ccid-card-passthru: Use QERR_MISSING_PARAMETER
ccid-card-passthru: Use size_t to hold size argument
ccid-card-passthru: Use size_t for index
hw/usb/ccid-card-passthru.c | 73 +++++++++++++++++-------------------- 1 file changed, 34 insertions(+), 39 deletions(-)
Signature · 1 line
2.20.1