Skip to content

tests: Add device unplug tests

David Hildenbrand qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 4 repliesIn review
  2. v26 patches 22 repliesSuperseded

Changes in v3 from the cover letter

- Use a smaller DIMM for spapr memory unplug request test
- Combine both spapr test registrations in a single if statement
- Use "-" instead of "_" in test names
- Add a huge load of r-b/a-b :) hpe I didn't forget some.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6cpus: Properly release the iothread lock when killing a dummy VCPUcpus.c+1 -00 replies
2/6spapr: support memory unplug for qtesthw/ppc/spapr_ovec.c+6 -00 replies
3/6tests/device-plug: Add a simple PCI unplug request testtests/Makefile.include tests/device-plug-test.c+97 -01 reply
4/6tests/device-plug: Add CCW unplug test for s390xtests/device-plug-test.c+36 -51 reply
5/6tests/device-plug: Add CPU core unplug request test for spaprtests/device-plug-test.c+20 -00 replies
6/6tests/device-plug: Add memory unplug request test for spaprtests/device-plug-test.c+18 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinGreg KurzThomas HuthDavid GibsonCollin WallingCornelia Huck
1/6R-b R-b R-b R-b
2/6R-b R-b A-b
3/6R-b R-b R-b R-b R-b A-b
4/6R-b R-b A-b
5/6R-b R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/6] tests: Add device unplug tests

This is a set of tests to test basic device unplugging functionality for
- some PCI implementations
- CCW devices on s390x
- spapr memory and cpu core devices

I plaed with ACPI CPU unplug but getting that to run with qtest is more involved. (remove devices on reset, trick cpu-hotplug-legacy property, somehow create cpu hotplug state objects ...). Well we no have at least one unplug test for DIMMs and one for CPUs.

v2 -> v3:
- Use a smaller DIMM for spapr memory unplug request test
- Combine both spapr test registrations in a single if statement
- Use "-" instead of "_" in test names
- Add a huge load of r-b/a-b :) hpe I didn't forget some.

v1 -> v2:
- Tests for CCW, spapr memory and spapr cpu core unplug added
- Fix a deadlock when unplugging dummy CPUs
- Style fixes / simplifications (Thomas)
- Don't use the global_qtest variable (Thomas)
- Fix double-free (Greg)

David Hildenbrand (6):
cpus: Properly release the iothread lock when killing a dummy VCPU
spapr: support memory unplug for qtest tests/device-plug: Add a simple PCI unplug request test tests/device-plug: Add CCW unplug test for s390x tests/device-plug: Add CPU core unplug request test for spapr tests/device-plug: Add memory unplug request test for spapr

 cpus.c                   |   1 +
 hw/ppc/spapr_ovec.c      |   6 ++
 tests/Makefile.include   |   4 +
 tests/device-plug-test.c | 162 +++++++++++++++++++++++++++++++++++++++
 4 files changed, 173 insertions(+)
 create mode 100644 tests/device-plug-test.c
Signature · 1 line
2.17.2