Skip to content

tcp: fix possible crash in tcp_v4_err()

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcp: clear icsk_backoff in tcp_write_queue_purge()net/ipv4/tcp.c+1 -11 reply
2/2tcp: tcp_v4_err() should be more carefulnet/ipv4/tcp_ipv4.c+4 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNeal CardwellSoheil Hassas Yeganeh
1/2A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] tcp: fix possible crash in tcp_v4_err()

soukjin bae reported a crash in tcp_v4_err() that we root caused to a missing initialization.

Second patch adds a sanity check in tcp_v4_err() to avoid future potential problems. Ignoring an ICMP message is probably better than crashing a machine.

Eric Dumazet (2):
tcp: clear icsk_backoff in tcp_write_queue_purge()
tcp: tcp_v4_err() should be more careful

 net/ipv4/tcp.c      | 2 +-
 net/ipv4/tcp_ipv4.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
2.21.0.rc0.258.g878e2cd30e-goog