Several patches to fix code bugs, improve documents and clean up
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 4 repliesIn review
- v36 patches 16 repliesSuperseded
Changes in v4 from the cover letter
Update patches according to Kees's reviewing comments:
- Fix typos and move operation comment above kernel_randomize_memory() for patch 1/6;
- Change 'PAGE_SIZE' to 'PAGE_SIZE/4' in patch 3/6;
- Add code comment about the calculation of vmemmap in patch 5/6;
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | x86/mm/KASLR: Improve code comments about struct kaslr_memory_regionarch/ | +47 | 0 replies | |
| 2/6 | x86/mm/KASLR: Open code unnecessary function get_paddingarch/ | +2 | 0 replies | |
| 3/6 | mm: Add build time sanity check for struct page sizemm/ | +2 | 2 replies | |
| 4/6 | x86/mm/KASLR: Fix the wrong calculation of memory region initial sizearch/ | +1 | 2 replies | |
| 5/6 | x86/mm/KASLR: Calculate the actual size of vmemmap regionarch/ | +20 | 0 replies | |
| 6/6 | x86/mm/KASLR: Do not adapt the size of the direct mapping region for SGI UV systemarch/ | +45 | 0 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook | Kirill A. Shutemov | Thomas Garnier |
|---|---|---|---|
| 1/6 | |||
| 2/6 | A-b | ||
| 3/6 | |||
| 4/6 | A-b | A-b | R-b |
| 5/6 | |||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/6] Several patches to fix code bugs, improve documents and clean up
This is v4 post. The v3 post can be found here:
http://lkml.kernel.org/r/[email protected]
The v2 post was here:
https://lkml.org/lkml/2018/9/9/56
This patchset includes the original three code bug fix patches in v2, and two new patches to improve code comments about kaslr_memory_region and open code unnecessary function get_padding(), meanwhile carry the known SGI UV bug fix.
This patchset sits on top of another patchset earlier posted:
http://lkml.kernel.org/r/[email protected]
[PATCH v3 0/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level [PATCH v3 2/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level [PATCH v3 1/2] x86/mm/KASLR: Only build one PUD entry of area for real mode trampoline
Note:
SGI UV bug fix is not tested yet, the idea was approved by SGI UV expert Mike Travis, and the old post as below was tested and has been merged into our RHEL distros. This new change doesn't change the way to calculate the size of the direct mapping section, but only wrap the calculation code into a new function calc_direct_mapping_size() according to Ingo's suggestion.
https://lkml.org/lkml/2017/5/18/102
Changelog:v3->v4:
Update patches according to Kees's reviewing comments:
- Fix typos and move operation comment above kernel_randomize_memory() for patch 1/6;
- Change 'PAGE_SIZE' to 'PAGE_SIZE/4' in patch 3/6;
- Add code comment about the calculation of vmemmap in patch 5/6;v2->v3:
Added three patches according to Ingo's suggestions:
- Add code comment about struct kaslr_memory_region;
- Open code get_padding();
- Carry the SGI UV fix;
Baoquan He (6):
x86/mm/KASLR: Improve code comments about struct kaslr_memory_region x86/mm/KASLR: Open code unnecessary function get_padding
mm: Add build time sanity chcek for struct page size x86/mm/KASLR: Fix the wrong calculation of memory region initial size x86/mm/KASLR: Calculate the actual size of vmemmap region x86/mm/KASLR: Do not adapt the size of the direct mapping region for
SGI UV system
arch/x86/mm/kaslr.c | 134 +++++++++++++++++++++++++++++++++++--------- mm/page_alloc.c | 2 + 2 files changed, 109 insertions(+), 27 deletions(-)
Signature · 1 line
2.17.2