Skip to content

RFC Consolidate Post read processing code

Chandan Rajendra linux-ext4 linux-f2fs-devel linux-fscrypt 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ext4: use IS_ENCRYPTED() to check encryption statusfs/ext4/dir.c fs/ext4/ext4.h fs/ext4/ext4_jbd2.h +7 more+22 -310 replies
2/10f2fs: use IS_ENCRYPTED() to check encryption statusfs/f2fs/data.c fs/f2fs/dir.c fs/f2fs/f2fs.h +3 more+18 -230 replies
3/10fscrypt: remove filesystem specific build config optionDocumentation/filesystems/fscrypt.rst arch/mips/configs/generic_defconfig arch/nds32/configs/defconfig +28 more+460 -5350 replies
4/10Consolidate "post read processing" into a new filefs/Makefile fs/crypto/bio.c fs/crypto/crypto.c +8 more+176 -1872 replies
5/10fsverity: Add call back to decide if verity check has to be performedfs/ext4/super.c fs/post_read_process.c include/linux/fsverity.h+13 -22 replies
6/10Introduce REQ_POST_READ_PROC bio flagfs/ext4/readpage.c fs/post_read_process.c include/linux/blk_types.h+12 -32 replies
7/10fsverity: Add call back to determine readpage limitfs/ext4/super.c include/linux/fsverity.h+19 -00 replies
8/10fsverity: Add call back to verify file holesfs/ext4/super.c include/linux/fsverity.h+2 -02 replies
9/10fs/mpage.c: Integrate post read processingfs/mpage.c+59 -180 replies
10/10ext4: Wire up ext4_readpage[s] to use mpage_readpage[s]fs/ext4/Makefile fs/ext4/inode.c fs/ext4/readpage.c+3 -3060 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchEric BiggersChao Yu
1/10R-b
2/10R-b A-b
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/10] Consolidate Post read processing code

This patchset moves the "post read processing" code into a file of its own and gets the generic do_mpage_readpge() to make use of the functionality provided. With these changes in place, the patchset changes Ext4 to use mpage_readpage[s] instead of its own custom ext4_readpages() function. This is done to reduce duplicity of code across filesystems. Based on the reviews provided for this patchset, I will change F2FS to use mpage_readpage[s] and post the next version of this patchset to linux-fsdevel mailing list.

The patchset also includes patches from previous postings i.e. patches to replace per-filesystem encryption config options with a single config option that affects all filesystems making use of fscrypt code.

Chandan Rajendra (10):
ext4: use IS_ENCRYPTED() to check encryption status
f2fs: use IS_ENCRYPTED() to check encryption status
fscrypt: remove filesystem specific build config option Consolidate "post read processing" into a new file
fsverity: Add call back to decide if verity check has to be performed Introduce REQ_POST_READ_PROC bio flag
fsverity: Add call back to determine readpage limit
fsverity: Add call back to verify file holes
fs/mpage.c: Integrate post read processing
ext4: Wire up ext4_readpage[s] to use mpage_readpage[s]

 Documentation/filesystems/fscrypt.rst   |   4 +-
 arch/mips/configs/generic_defconfig     |   2 +-
 arch/nds32/configs/defconfig            |   2 +-
 arch/s390/configs/debug_defconfig       |   2 +-
 arch/s390/configs/performance_defconfig |   2 +-
 fs/Makefile                             |   3 +-
 fs/crypto/Kconfig                       |   5 +-
 fs/crypto/bio.c                         |  21 +-
 fs/crypto/crypto.c                      |   1 +
 fs/crypto/fscrypt_private.h             |   4 +-
 fs/ext4/Kconfig                         |  15 -
 fs/ext4/Makefile                        |   2 +-
 fs/ext4/dir.c                           |  10 +-
 fs/ext4/ext4.h                          |  14 +-
 fs/ext4/ext4_jbd2.h                     |   2 +-
 fs/ext4/extents.c                       |   4 +-
 fs/ext4/ialloc.c                        |   2 +-
 fs/ext4/inode.c                         |  29 +-
 fs/ext4/ioctl.c                         |   4 +-
 fs/ext4/move_extent.c                   |   3 +-
 fs/ext4/namei.c                         |  18 +-
 fs/ext4/page-io.c                       |   9 +-
 fs/ext4/readpage.c                      | 444 ------------------------
 fs/ext4/super.c                         |  43 ++-
 fs/ext4/sysfs.c                         |   4 +-
 fs/f2fs/Kconfig                         |  12 +-
 fs/f2fs/data.c                          |   4 +-
 fs/f2fs/dir.c                           |  10 +-
 fs/f2fs/f2fs.h                          |  14 +-
 fs/f2fs/file.c                          |  10 +-
 fs/f2fs/inode.c                         |   4 +-
 fs/f2fs/namei.c                         |   6 +-
 fs/f2fs/super.c                         |   8 +-
 fs/f2fs/sysfs.c                         |   4 +-
 fs/mpage.c                              |  77 +++-
 fs/post_read_process.c                  | 128 +++++++
 fs/ubifs/Kconfig                        |  12 +-
 fs/ubifs/Makefile                       |   2 +-
 fs/ubifs/ioctl.c                        |   4 +-
 fs/ubifs/sb.c                           |   2 +-
 fs/ubifs/super.c                        |   2 +-
 fs/ubifs/ubifs.h                        |   5 +-
 fs/verity/verify.c                      |  12 +
 include/linux/blk_types.h               |   2 +
 include/linux/fs.h                      |   4 +-
 include/linux/fscrypt.h                 | 405 ++++++++++++++++++++-
 include/linux/fscrypt_notsupp.h         | 231 ------------
 include/linux/fscrypt_supp.h            | 204 -----------
 include/linux/fsverity.h                |   3 +
 include/linux/post_read_process.h       |  21 ++
 50 files changed, 757 insertions(+), 1078 deletions(-)
 delete mode 100644 fs/ext4/readpage.c
 create mode 100644 fs/post_read_process.c
 delete mode 100644 include/linux/fscrypt_notsupp.h
 delete mode 100644 include/linux/fscrypt_supp.h
 create mode 100644 include/linux/post_read_process.h
Signature · 1 line
2.19.1