Skip to content

net: phy: at803x: Update delays for RGMII modes

Vinod Koul linux-arm-msm netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 1 replyIn review
  2. v32 patches 5 repliesSuperseded
  3. v22 patches 7 repliesSuperseded

Changes in v4 from the cover letter

- fix log & comments nbased on Marc's feedback

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: phy: at803x: don't inline helpersdrivers/net/phy/at803x.c+2 -20 replies
2/2net: phy: at803x: disable delay only for RGMII modedrivers/net/phy/at803x.c+42 -110 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNiklas CasselPeter UjfalusiMarc Gonzalez
1/2R-b T-b R-b
2/2R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH net-next v4 0/2] net: phy: at803x: Update delays for RGMII modes

Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") caused regression on am335x-evmsk board. This board expects the Phy delay to be enabled but specified RGMII mode which refers to delays being disabled. So fix this by disabling delay only for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes.

While at it, as pointed by Dave, don't inline the helpers.

[1]: https://www.spinics.net/lists/netdev/msg550749.html

Changes in v4:
- fix log & comments nbased on Marc's feedback

Vinod Koul (2):
net: phy: at803x: don't inline helpers
net: phy: at803x: disable delay only for RGMII mode

 drivers/net/phy/at803x.c | 57 +++++++++++++++++++++++++++++++---------
 1 file changed, 44 insertions(+), 13 deletions(-)
Signature · 1 line
2.20.1