Skip to content

RFC sched: Core scheduling

Peter Zijlstra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest16 patches 82 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16stop_machine: Fix stop_cpus_in_progress orderingkernel/stop_machine.c+2 -00 replies
2/16sched: Fix kerneldoc comment for ia64_set_curr_taskkernel/sched/core.c+1 -10 replies
3/16sched: Wrap rq::lock accesskernel/sched/core.c kernel/sched/deadline.c kernel/sched/debug.c +6 more+114 -11318 replies
4/16sched/{rt,deadline}: Fix set_next_task vs pick_next_taskkernel/sched/deadline.c kernel/sched/rt.c+26 -240 replies
5/16sched: Add task_struct pointer to sched_class::set_curr_taskkernel/sched/core.c kernel/sched/deadline.c kernel/sched/fair.c +4 more+49 -460 replies
6/16sched/fair: Export newidle_balance()kernel/sched/fair.c kernel/sched/sched.h+12 -100 replies
7/16sched: Allow put_prev_task() to drop rq->lockkernel/sched/core.c kernel/sched/deadline.c kernel/sched/fair.c +4 more+32 -80 replies
8/16sched: Rework pick_next_task() slow-pathkernel/sched/core.c kernel/sched/deadline.c kernel/sched/fair.c +4 more+34 -730 replies
9/16sched: Introduce sched_class::pick_task()kernel/sched/deadline.c kernel/sched/fair.c kernel/sched/idle.c +3 more+89 -160 replies
10/16sched: Core-wide rq->lockkernel/Kconfig.preempt kernel/sched/core.c kernel/sched/sched.h+129 -10 replies
11/16sched: Basic tracking of matching tasksinclude/linux/sched.h kernel/sched/core.c kernel/sched/sched.h+156 -10 replies
12/16sched: A quick and dirty cgroup tagging interfacekernel/sched/core.c kernel/sched/sched.h+66 -00 replies
13/16sched: Add core wide task selection and scheduling.kernel/sched/core.c kernel/sched/sched.h+224 -319 replies
14/16sched/fair: Add a few assertionskernel/sched/fair.c+10 -20 replies
15/16sched: Trivial forced-newidle balancerinclude/linux/sched.h kernel/sched/core.c kernel/sched/idle.c +1 more+138 -16 replies
16/16sched: Debug bits...kernel/sched/core.c+35 -10 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16Not-Signed-off-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC][PATCH 00/16] sched: Core scheduling

A much 'demanded' feature: core-scheduling :-(

I still hate it with a passion, and that is part of why it took a little longer than 'promised'.

While this one doesn't have all the 'features' of the previous (never published) version and isn't L1TF 'complete', I tend to like the structure better (relatively speaking: I hate it slightly less).

This one is sched class agnostic and therefore, in principle, doesn't horribly wreck RT (in fact, RT could 'ab'use this by setting 'task->core_cookie = task' to force-idle siblings).

Now, as hinted by that, there are semi sane reasons for actually having this. Various hardware features like Intel RDT - Memory Bandwidth Allocation, work per core (due to SMT fundamentally sharing caches) and therefore grouping related tasks on a core makes it more reliable.

However; whichever way around you turn this cookie; it is expensive and nasty.

It doesn't help that there are truly bonghit crazy proposals for using this out there, and I really hope to never see them in code.

These patches are lightly tested and didn't insta explode, but no promises, they might just set your pets on fire.

'enjoy'

@pjt; I know this isn't quite what we talked about, but this is where I ended up after I started typing. There's plenty design decisions to question and my changelogs don't even get close to beginning to cover them all. Feel free to ask.

---
 include/linux/sched.h    |   9 +-
 kernel/Kconfig.preempt   |   8 +-
 kernel/sched/core.c      | 762 ++++++++++++++++++++++++++++++++++++++++++++---
 kernel/sched/deadline.c  |  99 +++---
 kernel/sched/debug.c     |   4 +-
 kernel/sched/fair.c      | 129 +++++---
 kernel/sched/idle.c      |  42 ++-
 kernel/sched/pelt.h      |   2 +-
 kernel/sched/rt.c        |  96 +++---
 kernel/sched/sched.h     | 183 ++++++++----
 kernel/sched/stop_task.c |  35 ++-
 kernel/sched/topology.c  |   4 +-
 kernel/stop_machine.c    |   2 +
 13 files changed, 1096 insertions(+), 279 deletions(-)