Add debug messages to v4l2-ctrls
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 6 repliesIn review
- v14 patches 1 replySuperseded
Changes in v2 from the cover letter
* Print the video device node name where possible, in v4l2-ctrls.c, by passing the struct video_device as a parameter.
* Added a warning to dev_debug attribute store, to warn the user about V4L2_DEV_DEBUG_CTRL being a no-op for dev_debug.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | media: v4l: Simplify dev_debug flagsdrivers/ | +2 | 2 replies | |
| 2/4 | media: v4l: Improve debug dprintk macrodrivers/ | +11 | 0 replies | |
| 3/4 | media: v4l: Add a module parameter to control global debuggingdrivers/ | +9 | 0 replies | |
| 4/4 | media: v4l: ctrls: Add debug messagesdrivers/ drivers/ drivers/ +3 more | +91 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/4] Add debug messages to v4l2-ctrls
v2:
* Print the video device node name where possible, in v4l2-ctrls.c, by passing the struct video_device as a parameter.
* Added a warning to dev_debug attribute store, to warn the user about V4L2_DEV_DEBUG_CTRL being a no-op for dev_debug.
Even though the goal was fairly simple (adding debug to v4l2-ctrls) it ended up spanning this little patchset.
The motivation for this cleanup is being able to turn on/off debugging messages in v4l2-ctrls.c, using a knob common to the videodev driver's core.
So, in addition to the dev_debug attribute, this series introduces a debug module parameter, and a new debug level, which enables v4l2-ctrl debugging.
Having this is quite useful when bringing-up stateless codecs, using the Request API.
Ezequiel Garcia (4):
media: v4l: Simplify dev_debug flags
media: v4l: Improve debug dprintk macro
media: v4l: Add a module parameter to control global debugging
media: v4l: ctrls: Add debug messages
drivers/media/v4l2-core/v4l2-ctrls.c | 93 +++++++++++++++++++++------ drivers/media/v4l2-core/v4l2-dev.c | 47 ++++++-------- drivers/media/v4l2-core/v4l2-ioctl.c | 8 +-- drivers/media/v4l2-core/v4l2-subdev.c | 4 +- include/media/v4l2-ctrls.h | 9 ++- include/media/v4l2-ioctl.h | 2 + 6 files changed, 110 insertions(+), 53 deletions(-)
Signature · 1 line
2.20.1