Skip to content

MTD: Add Initial Hyperbus support

Vignesh Raghavendra linux-arm-kernel linux-devicetree linux-mtd lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 13 repliesIn review
  2. v75 patches 7 repliesSuperseded
  3. v65 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v55 patches7 repliesSuperseded
v45 patches5 repliesSuperseded
v3 posting 2/25 patches1 replySuperseded
v3 posting 1/25 patches6 repliesSuperseded
v2 RFC5 patches12 repliesSuperseded
v1 RFC5 patches19 repliesSuperseded

Changes in v8 from the cover letter

Fix up status register polling to support banked flashes in patch 1/5. Fix up comments by Sergei on documentation and style

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mtd: cfi_cmdset_0002: Add support for polling status registerdrivers/mtd/chips/cfi_cmdset_0002.c include/linux/mtd/cfi.h+120 -172 replies
2/5dt-bindings: mtd: Add binding documentation for HyperFlashDocumentation/devicetree/bindings/mtd/cypress,hyperflash.txt+13 -00 replies
3/5mtd: Add support for HyperBus memory devicesMAINTAINERS drivers/mtd/Kconfig drivers/mtd/Makefile +4 more+264 -010 replies
4/5dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controllerDocumentation/devicetree/bindings/mtd/ti,am654-hbmc.txt MAINTAINERS+52 -00 replies
5/5mtd: hyperbus: Add driver for TI's HyperBus memory controllerdrivers/mtd/hyperbus/Kconfig drivers/mtd/hyperbus/Makefile drivers/mtd/hyperbus/hbmc-am654.c+154 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchRob HerringTokunori Ikegami
1/5R-b
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/5] MTD: Add Initial Hyperbus support

Change log:
Since v7:
Fix up status register polling to support banked flashes in patch 1/5. Fix up comments by Sergei on documentation and style

Since v6:
Fix up DT bindings for TI HBMC driver to move hyperbus node out of syscon

Since v5:
Fix up DT bindings comments for TI HBMC driver Move calibration sequence out of core into TI HBMC driver

Since v4:
Fix Rob's comments on dt-bindings of TI HBMC driver

Since v3:
* Drop reading QRY string twice in hyperbus_calibrate()
* Fix doc/misc comments on v3.

Since RFC v2:
* use map_word_xxx() for handling status register to support interleaved flashes as suggested by Joakim Tjernlund <[email protected]>
* Report error status/messages on erase/program failure by looking at status register bits.
* Add "cfi-flash" as fallback compatible for cypress,hyperflash
* Add support to select between HyperBus and OSPI using mmio mux

Since RFC v1:
* Re-work Hyperbus core to provide separate struct representation for controller and slave devices
* Rename all files and func names to have hyperbus_ prefix
* Provide default calibration routine for use by controller drivers
* Fix up errors with patch spliting
* Address comments by Sergei Shtylyov <[email protected]> Cypress HyperBus is Low Signal Count, High Performance Double Data Rate Bus interface between a host system master and one or more slave interfaces. HyperBus is used to connect microprocessor, microcontroller, or ASIC devices with random access NOR flash memory(called HyperFlash) or self refresh DRAM(called HyperRAM).

Its a 8-bit data bus (DQ[7:0]) with Read-Write Data Strobe (RWDS) signal and either Single-ended clock(3.0V parts) or Differential clock (1.8V parts). It uses ChipSelect lines to select b/w multiple slaves. At bus level, it follows a separate protocol described in HyperBus specification[1].

HyperFlash follows CFI AMD/Fujitsu Extended Command Set (0x0002) similar to that of existing parallel NORs. Since Hyperbus is x8 DDR bus, its equivalent to x16 parallel NOR flash wrt bits per clk. But Hyperbus operates at >166MHz frequencies.
HyperRAM provides direct random read/write access to flash memory array.
Framework is modelled along the lines of spi-nor framework. HyperBus memory controller(HBMC) drivers call hyperbus_register_device() to register a single HyperFlash device. HyperFlash core parses MMIO access information from DT, sets up the map_info struct, probes CFI flash and registers it with MTD framework.

This is an early RFC, to know if its okay to use maps framework and existing CFI compliant flash support code to support Hyperflash
Also would like input on different types of HBMC master IPs out there and their programming sequences.
Would appreciate any testing/review.

Tested on modified TI AM654 EVM with Cypress Hyperflash S26KS512 by creating a UBIFS partition and writing and reading files to it. Stress tested by writing/reading 16MB flash repeatedly at different offsets using dd commmand.

HyperBus specification can be found at[1]
HyperFlash datasheet can be found at[2]
TI's HBMC controller details at[3]

[1] https://www.cypress.com/file/213356/download
[2] https://www.cypress.com/file/213346/download
[3] http://www.ti.com/lit/ug/spruid7b/spruid7b.pdf
Table 12-5741. HyperFlash Access Sequence

Vignesh Raghavendra (5):
mtd: cfi_cmdset_0002: Add support for polling status register
dt-bindings: mtd: Add binding documentation for HyperFlash
mtd: Add support for HyperBus memory devices
dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory
controller
mtd: hyperbus: Add driver for TI's HyperBus memory controller

 .../bindings/mtd/cypress,hyperflash.txt       |  13 ++
 .../devicetree/bindings/mtd/ti,am654-hbmc.txt |  51 ++++++
 MAINTAINERS                                   |   8 +
 drivers/mtd/Kconfig                           |   2 +
 drivers/mtd/Makefile                          |   1 +
 drivers/mtd/chips/cfi_cmdset_0002.c           | 130 +++++++++++++--
 drivers/mtd/hyperbus/Kconfig                  |  23 +++
 drivers/mtd/hyperbus/Makefile                 |   4 +
 drivers/mtd/hyperbus/hbmc-am654.c             | 141 ++++++++++++++++
 drivers/mtd/hyperbus/hyperbus-core.c          | 154 ++++++++++++++++++
 include/linux/mtd/cfi.h                       |   7 +
 include/linux/mtd/hyperbus.h                  |  86 ++++++++++
 12 files changed, 603 insertions(+), 17 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/cypress,hyperflash.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
 create mode 100644 drivers/mtd/hyperbus/Kconfig
 create mode 100644 drivers/mtd/hyperbus/Makefile
 create mode 100644 drivers/mtd/hyperbus/hbmc-am654.c
 create mode 100644 drivers/mtd/hyperbus/hyperbus-core.c
 create mode 100644 include/linux/mtd/hyperbus.h
Signature · 1 line
2.22.0