Skip to content

Fixes and enhancements for Tx path in Virtio PMD

Tiwei Bie dpdk-dev 1 version Applied

Status from this message: Applied to dpdk-next-virtio/master.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5net/virtio: fix Tx desc cleanup for packed ringdrivers/net/virtio/virtio_rxtx.c+0 -11 reply
2/5net/virtio: fix in-order Tx path for split ringdrivers/net/virtio/virtio_rxtx.c+10 -181 reply
3/5net/virtio: fix in-order Tx path for packed ringdrivers/net/virtio/virtio_ethdev.c drivers/net/virtio/virtio_rxtx.c+59 -141 reply
4/5net/virtio: introduce a helper for clearing net headerdrivers/net/virtio/virtio_rxtx.c+18 -281 reply
5/5net/virtio: optimize xmit enqueue for packed ringdrivers/net/virtio/virtio_rxtx.c+61 -23 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMaxime Coquelin
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Fixes and enhancements for Tx path in Virtio PMD

Below is a quick (unofficial) performance test (macfwd loop, 64B) for the packed ring optimizations in this series on an Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz platform:

w/o this series:
packed ring normal/in-order: ~10.4 Mpps

w/ this series:

packed ring normal:           ~10.9 Mpps
packed ring in-order:         ~11.3 Mpps

In the test, we need to make sure that the vhost side is fast enough. So 4 forwarding cores are used in vhost side, and 1 forwarding core is used in virtio side.

vhost side:

./x86_64-native-linuxapp-gcc/app/testpmd \
        -l 13,14,15,16,17 \
        --socket-mem 1024,0 \
        --file-prefix=vhost \
        --vdev=net_vhost0,iface=/tmp/vhost0,queues=4 \
        -- \
        --forward-mode=mac \
        -i \
        --rxq=4 \
        --txq=4 \
        --nb-cores 4

virtio side:

./x86_64-native-linuxapp-gcc/app/testpmd \
        -l 8,9,10,11,12 \
        --socket-mem 1024,0 \
        --single-file-segments \
        --file-prefix=virtio-user \
        --vdev=virtio_user0,path=/tmp/vhost0,queues=4,in_order=1,packed_vq=1 \
        -- \
        --forward-mode=mac \
        -i \
        --rxq=4 \
        --txq=4 \
        --nb-cores 1

Tiwei Bie (5):
net/virtio: fix Tx desc cleanup for packed ring net/virtio: fix in-order Tx path for split ring net/virtio: fix in-order Tx path for packed ring net/virtio: introduce a helper for clearing net header net/virtio: optimize xmit enqueue for packed ring

 drivers/net/virtio/virtio_ethdev.c |   4 +-
 drivers/net/virtio/virtio_rxtx.c   | 203 ++++++++++++++++++++---------
 2 files changed, 146 insertions(+), 61 deletions(-)
Signature · 1 line
2.17.1