Skip to content

PCI: fix pci-mvebu after conversion to common bridge emul code

Thomas Petazzoni linux-arm-kernel linux-pci 1 version Applied

Status from this message: I have applied the series to pci/misc for v5.1, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2PCI: pci-bridge-emul: Create per-bridge copy of register behaviordrivers/pci/pci-bridge-emul.c drivers/pci/pci-bridge-emul.h+60 -281 reply
2/2PCI: pci-bridge-emul: Extend pci_bridge_emul_init() with flagsdrivers/pci/controller/pci-aardvark.c drivers/pci/controller/pci-mvebu.c drivers/pci/pci-bridge-emul.c +1 more+15 -41 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLuis MendesBjorn HelgaasLeigh Brown
SeriesA-b T-b
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] PCI: fix pci-mvebu after conversion to common bridge emul code

Hello,

This set of two patches aim at fixing some regression reported by two users (Luis and Leigh), that were introduced by the conversion of the pci-mvebu driver to the common PCI bridge emulation code shared between pci-aardvark and pci-mvebu.

Due to this conversion, some registers of the PCI configuration that used to be read-only are now read-write, making the Linux PCI core believe that some features are implemented by the PCI bridge. Namely in the case of pci-mvebu, the prefetchable memory base/limit registers were read-only, while they are now read-write. Due to this, the Linux PCI core now believes it can configure a prefetchable memory area, but this is not supported by pci-mvebu, which does not have the logic to create the appropriate MBUs windows.

This set of two commits allow PCI controller code to tell the PCI bridge emulation logic about their capabilities. Because we envision that other capabilities than prefetchable memory support might need to be communicated from the PCI controller code to the PCI bridge emulation code in the future, we introduce a "flags" argument, even if for now only one flag is supported.

Lorenzo, let me know what you think about this approach. I am open to suggestions if the proposed approach is not satisfying.

Both patches have been confirmed by Luis and Leigh to fix the regression, but I'll let them give a formal Tested-by.

Best regards,

Thomas Petazzoni

Thomas Petazzoni (2):
PCI: pci-bridge-emul: Create per-bridge copy of register behavior
PCI: pci-bridge-emul: Extend pci_bridge_emul_init() with flags

 drivers/pci/controller/pci-aardvark.c |  2 +-
 drivers/pci/controller/pci-mvebu.c    |  2 +-
 drivers/pci/pci-bridge-emul.c         | 86 ++++++++++++++++++---------
 drivers/pci/pci-bridge-emul.h         | 13 +++-
 4 files changed, 73 insertions(+), 30 deletions(-)
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel