Skip to content

Fix most ImgU driver compiler / checker warnings

Sakari Ailus linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v15 patches 4 repliesSuperseded

since v2 from the cover letter

- Drop __attribute__((aligned())) -> __aligned() change for now

- Align awb_fr field in struct ipu3_uapi_acc_param

- Add Raj's Tested-by: tag

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: imgu: Address a compiler warning on alignmentdrivers/staging/media/ipu3/include/intel-ipu3.h+1 -14 replies
2/4staging: imgu: Remove redundant checksdrivers/staging/media/ipu3/ipu3-css-fw.c+2 -40 replies
3/4staging: imgu: Address compiler / checker warnings in MMU codedrivers/staging/media/ipu3/ipu3-mmu.c+35 -40 replies
4/4Revert "media: ipu3: shut up warnings produced with W=1"drivers/staging/media/ipu3/Makefile drivers/staging/media/ipu3/TODO+0 -80 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchRajmohan Mani
1/4T-b
2/4T-b
3/4T-b
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Fix most ImgU driver compiler / checker warnings

Hi Mauro, Hans,

This set addresses most of the compiler / checker warnings from the ImgU driver. There are a few about stack usage from the compiler left but those were not trivial to address so I postponed that. There are also a few about memset but Hans suggested addressing that by increasing the maximum size. I guess it wouldn't benefit anyone to split those memsets into two...

since v2:

- Drop __attribute__((aligned())) -> __aligned() change for now

- Align awb_fr field in struct ipu3_uapi_acc_param

- Add Raj's Tested-by: tag

Sakari Ailus (4):
staging: imgu: Address a compiler warning on alignment
staging: imgu: Remove redundant checks
staging: imgu: Address compiler / checker warnings in MMU code Revert "media: ipu3: shut up warnings produced with W=1"

 drivers/staging/media/ipu3/Makefile             |  6 ----
 drivers/staging/media/ipu3/TODO                 |  2 --
 drivers/staging/media/ipu3/include/intel-ipu3.h |  2 +-
 drivers/staging/media/ipu3/ipu3-css-fw.c        |  6 ++--
 drivers/staging/media/ipu3/ipu3-mmu.c           | 39 ++++++++++++++++++++++---
 5 files changed, 38 insertions(+), 17 deletions(-)
Signature · 1 line
2.11.0