Skip to content

Multifd compression support

Juan Quintela qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 3 repliesIn review
  2. v38 patches 30 repliesSuperseded
  3. v28 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Changes in v4 from the cover letter

- improve the code left and right
- use the MIGRATION_FLAG_SYNC
- use qerrors properly
- pass errors everywhere (no more printfs)
- create cleanup/save operations
- merged zlib patches into one
- general patches alreody on the migration pull request.
- commented all the methods.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6migration-test: introduce functions to handle string parameterstests/migration-test.c+37 -00 replies
2/6migration: Make multifd_save_setup() get an Error parametermigration/migration.c migration/ram.c migration/ram.h+3 -30 replies
3/6migration: Make multifd_load_setup() get an Error parametermigration/migration.c migration/migration.h migration/ram.c +2 more+9 -90 replies
4/6migration: Add multifd-compress parameterhmp.c hw/core/qdev-properties.c include/hw/qdev-properties.h +3 more+79 -60 replies
5/6migration: Make no compression operations into its own structuremigration/migration.c migration/migration.h migration/ram.c+190 -82 replies
6/6migration: Add zlib compression multifd supporthw/core/qdev-properties.c migration/ram.c qapi/migration.json +1 more+270 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/6] Multifd compression support

v4:
- improve the code left and right
- use the MIGRATION_FLAG_SYNC
- use qerrors properly
- pass errors everywhere (no more printfs)
- create cleanup/save operations
- merged zlib patches into one
- general patches alreody on the migration pull request.
- commented all the methods.

ToDo: Didn't add the sztd compression because I changed the zlib
code/methods quite a bit.
My understanding is that all the issues are gone.

v3:
- improve the code
- address David and Markus comments
- make compression code into methods
so we can add any other method ading just three functions

Please review, as far as I know everything is ok now.

Todo: Add zstd support

v2:
- improve the code left and right
- Split better the zlib code
- rename everything to v4.1
- Add tests for multifd-compress zlib
- Parameter is now an enum (soon will see sztd)

ToDo:
- Make operations for diferent methods:
* multifd_prepare_send_none/zlib
* multifd_send_none/zlib
* multifd_recv_none/zlib
- Use the MULTIFD_FLAG_ZLIB (it is unused so far).

Please review and comment.

v1:

This series create compression code on top of multifd. It is still WIP, but it is already:
- faster that current compression code
- it does the minimum amount of copies possible
- we allow support for other compression codes
- it pass the multifd test sent in my previous series

Test for existing code didn't work because code is too slow, I need to make downtime 10 times bigger to make it to converge on my test machine. This code works with same limits that multifd no-

ToDo:
- move printf's to traces
- move code to a struct instead of if (zlib) inside the main threads.
- improve error handling.

Please, review and coment.

Juan Quintela (6):
migration-test: introduce functions to handle string parameters
migration: Make multifd_save_setup() get an Error parameter
migration: Make multifd_load_setup() get an Error parameter
migration: Add multifd-compress parameter
migration: Make no compression operations into its own structure
migration: Add zlib compression multifd support

 hmp.c                        |  13 +
 hw/core/qdev-properties.c    |  13 +
 include/hw/qdev-properties.h |   3 +
 migration/migration.c        |  34 ++-
 migration/migration.h        |   3 +-
 migration/ram.c              | 454 ++++++++++++++++++++++++++++++++++-
 migration/ram.h              |   4 +-
 migration/rdma.c             |   2 +-
 qapi/migration.json          |  30 ++-
 tests/migration-test.c       |  54 ++++-
 10 files changed, 585 insertions(+), 25 deletions(-)
Signature · 1 line
2.21.0