Skip to content

fix handling of bitfields in btf_loader

Andrii Nakryiko bpf 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btfdiff: support specifying custom pahole locationbtfdiff+3 -20 replies
2/3pahole: complete list of base type namesdwarves.c+3 -00 replies
3/3btf_loader: fix bitfield fixup codebtf_loader.c+14 -70 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrii Nakryiko
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH pahole 0/3] fix handling of bitfields in btf_loader

This patchset fixes the logic of determining bitfield_offsets and initial bit_offset when using BTF type information. It eliminates all the remaining discrepancies, when doing btfdiff on vmlinux image, module two instances of incorrectly reporting struct member type name when bitfield is the very first field in a struct, which is only happening when using DWARF data.

Patch #1 makes btfdiff script easier to use during local development.

Patch #2 fixes list of known base type names to handle clang-generated type descriptions better.

Patch #3 fixes bitfield handling logic in btf_loader.

Andrii Nakryiko (3):
btfdiff: support specifying custom pahole location
pahole: complete list of base type names
btf_loader: fix bitfield fixup code

 btf_loader.c | 21 ++++++++++++++-------
 btfdiff      |  5 +++--
 dwarves.c    |  3 +++
 3 files changed, 20 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.1