Makefile: allow for combining DEVELOPER= and CFLAGS="..."
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 11 repliesIn review
- v11 patch 1 replySuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Makefile: remove an out-of-date commentMakefile | +0 | 0 replies | |
| 2/6 | Makefile: move "strip" assignment down from flagsMakefile | +1 | 3 replies | |
| 3/6 | Makefile: add/remove comments at top and tweak whitespaceMakefile | +3 | 0 replies | |
| 4/6 | Makefile: Move *_LIBS assignment into its own sectionMakefile | +3 | 2 replies | |
| 5/6 | Makefile: move the setting of *FLAGS closer to "include"Makefile | +22 | 1 reply | |
| 6/6 | Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."Makefile config.mak.dev | +28 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..."
This fixes a long-standing annoyance of mine of not being able to set my own CFLAGS combined with DEVELOPER="...".
There *should* be no other functional changes, but I'm moving around some core Makefile logic, so this needs to be carefully reviewed.
I've tried installing with this, setting flags involved etc. It works as expected, but we have no tests for the Makefile itself, so I might have missed something.
I sent a stand-alone "Makefile: remove an out-of-date comment"[1] a bit too soon as it turns out. I thought it could be stand-alone, but as it turns out I needed to move some code adjacent to it. It would conflict with this, so it's now bundled up with it as a v2.
1. https://public-inbox.org/git/[email protected]/
Ævar Arnfjörð Bjarmason (6):
Makefile: remove an out-of-date comment
Makefile: move "strip" assignment down from flags
Makefile: add/remove comments at top and tweak whitespace
Makefile: Move *_LIBS assignment into its own section
Makefile: move the setting of *FLAGS closer to "include"
Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."
Makefile | 63 ++++++++++++++++++++++++++------------------------ config.mak.dev | 44 +++++++++++++++++------------------ 2 files changed, 55 insertions(+), 52 deletions(-)
Signature · 1 line
2.21.0.rc2.1.g2d5e20a900.dirty