Skip to content

spi: bcm2835aux: bug fixes and improvements

[email protected] linux-arm-kernel linux-spi 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 2 repliesIn review
  2. v29 patches 10 repliesSuperseded
  3. v19 patches 2 repliesSuperseded

Changelog from the cover letter

V1 -> V2: reordering commits as per request of Stefan Wahren
to help backporting the "essential" bugfixes go in first remove the dependency on a different patchset focused on making cs_change delay configurable
V2 -> V3: incorporated feedback by Stefan Wahren

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9spi: bcm2835aux: unifying code between polling and interrupt driven codedrivers/spi/spi-bcm2835aux.c+18 -330 replies
2/9spi: bcm2835aux: remove dangerous uncontrolled read of fifodrivers/spi/spi-bcm2835aux.c+0 -70 replies
3/9spi: bcm2835aux: fix corruptions for longer spi transfersdrivers/spi/spi-bcm2835aux.c+4 -40 replies
4/9spi: bcm2835aux: remove dead codedrivers/spi/spi-bcm2835aux.c+0 -30 replies
5/9spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpiosdrivers/spi/spi-bcm2835aux.c+12 -11 reply
6/9spi: bcm2835aux: warn in dmesg that native cs is not really supporteddrivers/spi/spi-bcm2835aux.c+33 -00 replies
7/9spi: bcm2835aux: setup gpio-cs to output and correct level during setupdrivers/spi/spi-bcm2835aux.c+14 -20 replies
8/9spi: bcm2835aux: add driver stats to debugfsdrivers/spi/spi-bcm2835aux.c+56 -00 replies
9/9spi: bcm2835aux: make the polling duration limits configurabledrivers/spi/spi-bcm2835aux.c+14 -110 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Wahren
SeriesA-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/9] spi: bcm2835aux: bug fixes and improvements

From: Martin Sperl <[email protected]>

Set of patches improving the spi-bcm2835aux driver and fixing a data read corruption bug.

The main motivation is a rare data corruption fix that is mostly observed in polling mode first reported by Hubert Denkmair.

So this patchset first implements a means to control the parameters of when polling mode is used via module parameters and exports the corresponding statistics.

As stated in original patch the driver does not support native CS. But when cs-gpios is not configured in the dt (so a buggy dt) it is still working with a lot of limitations, but the driver does not report this fact.

So this patchset adds reporting and allows for a single native CS (with limited functionality) to continue working with a buggy DT. One question here remains: do we need to legacy support DTs that are not following specs in the first place?

Then there is the real fix for the data-corruption which is split into 3 parts: some code cleanup with code reuse, removing "dangerous" fifo read (possibly introducing fifo data corruption) and safe fifo read.

Also we remove some dead code.

---
Changelog:
V1 -> V2: reordering commits as per request of Stefan Wahren
to help backporting the "essential" bugfixes go in first remove the dependency on a different patchset focused on making cs_change delay configurable
V2 -> V3: incorporated feedback by Stefan Wahren

Martin Sperl (9):
spi: bcm2835aux: unifying code between polling and interrupt driven
code
spi: bcm2835aux: remove dangerous uncontrolled read of fifo
spi: bcm2835aux: fix corruptions for longer spi transfers
spi: bcm2835aux: remove dead code
spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpios
spi: bcm2835aux: warn in dmesg that native cs is not really supported
spi: bcm2835aux: setup gpio-cs to output and correct level during
setup
spi: bcm2835aux: add driver stats to debugfs
spi: bcm2835aux: make the polling duration limits configurable

 drivers/spi/spi-bcm2835aux.c | 204 +++++++++++++++++++++++++++++++------------
 1 file changed, 147 insertions(+), 57 deletions(-)

--
2.11.0