Skip to content

lib/string: Add strscpy_pad() function

Tobin C. Harding kernel-hardening linux-kselftest lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 5 repliesIn review
  2. v37 patches 19 repliesSuperseded
  3. v21 patch 5 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6lib/test_printf: Add empty module_exit functionlib/test_printf.c+6 -00 replies
2/6kselftest: Add test runner creation scripttools/testing/selftests/kselftest_module.sh tools/testing/selftests/lib/bitmap.sh tools/testing/selftests/lib/prime_numbers.sh +1 more+88 -502 replies
3/6kselftest: Add test module framework headerDocumentation/dev-tools/kselftest.rst tools/testing/selftests/kselftest_module.h+140 -20 replies
4/6lib: Use new kselftest headerlib/test_bitmap.c lib/test_printf.c+9 -340 replies
5/6lib/string: Add strscpy_pad() functioninclude/linux/string.h lib/string.c+44 -70 replies
6/6lib: Add test module for strscpy_padlib/Kconfig.debug lib/Makefile lib/test_strscpy.c +3 more+159 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchKees Cook
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] lib/string: Add strscpy_pad() function

Hi Shua,

Here is the set with cleanup as suggested by Kees on v3.

Configured, built, and tested all modules loaded by tools/testing/selftests/lib/*.sh

Quoted 1 line

From previous cover letters ...

While doing the testing for strscpy_pad() it was noticed that there is duplication in how test modules are being fed to kselftest and also in the test modules themselves.

This set makes an attempt at adding a framework to kselftest for writing kernel test modules. It also adds a script for use in creating script test runners for kselftest. My macro-foo is not great, all criticism and suggestions very much appreciated. The design is based on test modules lib/test_printf.c, lib/test_bitmap.c, lib/test_xarray.c.

Changes since last version:

- Remove dependency on Bash (thanks Kees)
- Use oneliner to implement kselftest test runners (thanks Kees)
- Squash patch that adds kselftest script creator script with patch that uses it.
- Fix typos (thanks Randy)
- Add Kees' Acked-by tags to all patches

thanks,
Tobin.

Tobin C. Harding (6):
lib/test_printf: Add empty module_exit function
kselftest: Add test runner creation script
kselftest: Add test module framework header
lib: Use new kselftest header
lib/string: Add strscpy_pad() function
lib: Add test module for strscpy_pad

 Documentation/dev-tools/kselftest.rst        |  94 +++++++++++-
 include/linux/string.h                       |   4 +
 lib/Kconfig.debug                            |   3 +
 lib/Makefile                                 |   1 +
 lib/string.c                                 |  47 +++++-
 lib/test_bitmap.c                            |  20 +--
 lib/test_printf.c                            |  17 +--
 lib/test_strscpy.c                           | 150 +++++++++++++++++++
 tools/testing/selftests/kselftest_module.h   |  48 ++++++
 tools/testing/selftests/kselftest_module.sh  |  84 +++++++++++
 tools/testing/selftests/lib/Makefile         |   2 +-
 tools/testing/selftests/lib/bitmap.sh        |  18 +--
 tools/testing/selftests/lib/config           |   1 +
 tools/testing/selftests/lib/prime_numbers.sh |  17 +--
 tools/testing/selftests/lib/printf.sh        |  19 +--
 tools/testing/selftests/lib/strscpy.sh       |   3 +
 16 files changed, 440 insertions(+), 88 deletions(-)
 create mode 100644 lib/test_strscpy.c
 create mode 100644 tools/testing/selftests/kselftest_module.h
 create mode 100755 tools/testing/selftests/kselftest_module.sh
 create mode 100755 tools/testing/selftests/lib/strscpy.sh
Signature · 1 line
2.21.0